Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scanpy-scripts: require anndata >=0.8.0 (previously unversioned) #45534

Closed

Conversation

swbioinf
Copy link

@swbioinf swbioinf commented Feb 1, 2024

Added a requirement of AnnData >=0.8.0 (previously unversioned) for scanpy-scripts. I have incremented build version from 0=>1.

AnnData objects saved with > 0.8.0 (Mar 2022) are not backwards compatible with objects saved with current AnnData versions (e.g. current 0.10.5) https://anndata.readthedocs.io/en/latest/release-notes/index.html#version-0-8
Scanpy and scanpy-scripts will work in isolation with either version, but when data objects are shared between tools, issues arise.

I expect for most users/builds this will not affect much about the build (since it should default to the latest anndata), but in the case where an old version of anndata is available in a higher priority channel, this will mean a current version is sought. This particuar edge case has been seen in galaxy tool builds via biocontainers; See #45164 and ebi-gene-expression-group/container-galaxy-sc-tertiary#311 for details.

Its been a couple of years now, so I anticipate that there will not be many people wanting to stick with the old library. Is it fair to assume they can seek the previous build version (0) of this recipe if required? This is my first recipie update, so if I should be seeking a different aproach to this pull request please advise and I'll check it out. Thanks.

@pcm32
Copy link
Member

pcm32 commented Feb 11, 2024

Please do not merge this, as it might create a new container on the same version of scanpy-scripts which will break most of our setup. We are testing the update of scanpy scripts to 1.9.x scanpy which will include a newer AnnData.

@pcm32
Copy link
Member

pcm32 commented Feb 11, 2024

To clarify, these tests:

https://github.com/ebi-gene-expression-group/scanpy-scripts/blob/develop/scanpy-scripts-tests.bats

are not tested in bioconda and they need to pass. A fresh install of the bioconda recipe as it is just changing the anndata pin doesn't pass these tests. We have now merged changes on scanpy scripts to use a newer Scanpy (and drag with that a newer AnnData) (see ebi-gene-expression-group/scanpy-scripts#117)

@pcm32
Copy link
Member

pcm32 commented Feb 11, 2024

@swbioinf if you want to help us, I'm attaching the planemo report with changes needed on the Galaxy wrappers for Scanpy 1.9.x. in this PR ebi-gene-expression-group/container-galaxy-sc-tertiary#313 - just declare on which tools you will work and contribute to the branch on that PR. Thanks!

@swbioinf
Copy link
Author

Hi @pcm32 No worries - no I'm discontinuing this particular pull request (will close). I started this and realised when I hit the pinned version testing errors that it was (of course) not so simple! Thanks.

@swbioinf swbioinf closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants