Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protestar #47764

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add protestar #47764

wants to merge 5 commits into from

Conversation

agudys
Copy link
Contributor

@agudys agudys commented May 8, 2024

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

- {{ pin_subpackage('protestar', max_pin='x.x.x') }}

source:
git_url: https://github.com/refresh-bio/protestar.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
The reason we have used git_url is the presence of submodules, which are not included in release tarballs. However, as protestar developers, we have a full control on version tags, thus we believe using git_url is similarly safe as using releases.

We have different problem, though. We use some modern C++ multithreading features that require g++-11 for compilation. Unfortunately, these features are not supported by clang. Therefore, I would like to know if there is some workaround to install g++ in macOS conda environment in order to build a package.

Best Regards,
Adam

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be precise, the question about g++ on macOS environment actually concerns some other packages we plan to submit to bioconda, not protestar.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could achieve this by using custom conda_build_config.yaml with contents like:

c_compiler:
  - gcc                        # [linux or osx]
cxx_compiler:
  - gxx                        # [linux or osx]

See https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/a7b5c2d598ef642f911f9a0055ddf92666c6af08/recipe/conda_build_config.yaml for all defaults.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the response! Unfortunately, I got the following message in macOS environment (I have altered also c_compiler_version and cxx_compiler_version to 12 so it does not search for g++-16):

10:15:34 BIOCONDA INFO (ERR) The following packages are incompatible
10:15:34 BIOCONDA INFO (ERR) ├─ gcc_osx-64 12.*  does not exist (perhaps a typo or a missing channel);
10:15:34 BIOCONDA INFO (ERR) └─ gxx_osx-64 12.*  does not exist (perhaps a typo or a missing channel).

Do you have an idea, how to fix this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem actually concerns #49740 pull request.

about:
home: https://github.com/refresh-bio/protestar
summary: "Protein Structures Archiver"
license: GPL-3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license: GPL-3
license: GPL-3-only

Please use SPDX ids

home: https://github.com/refresh-bio/protestar
summary: "Protein Structures Archiver"
license: GPL-3
license_family: GPL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license_family: GPL
license_family: GPL3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants