Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protestar #47764

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions recipes/protestar/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/bin/bash
make protestar -j${CPU_COUNT}
install -d "${PREFIX}/bin"
install protestar "${PREFIX}/bin"


38 changes: 38 additions & 0 deletions recipes/protestar/meta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{% set version = "1.1.0" %}


package:
name: protestar
version: {{ version }}

build:
number: 0
run_exports:
- {{ pin_subpackage('protestar', max_pin='x.x.x') }}

source:
git_url: https://github.com/refresh-bio/protestar.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
The reason we have used git_url is the presence of submodules, which are not included in release tarballs. However, as protestar developers, we have a full control on version tags, thus we believe using git_url is similarly safe as using releases.

We have different problem, though. We use some modern C++ multithreading features that require g++-11 for compilation. Unfortunately, these features are not supported by clang. Therefore, I would like to know if there is some workaround to install g++ in macOS conda environment in order to build a package.

Best Regards,
Adam

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be precise, the question about g++ on macOS environment actually concerns some other packages we plan to submit to bioconda, not protestar.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could achieve this by using custom conda_build_config.yaml with contents like:

c_compiler:
  - gcc                        # [linux or osx]
cxx_compiler:
  - gxx                        # [linux or osx]

See https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/a7b5c2d598ef642f911f9a0055ddf92666c6af08/recipe/conda_build_config.yaml for all defaults.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the response! Unfortunately, I got the following message in macOS environment (I have altered also c_compiler_version and cxx_compiler_version to 12 so it does not search for g++-16):

10:15:34 BIOCONDA INFO (ERR) The following packages are incompatible
10:15:34 BIOCONDA INFO (ERR) ├─ gcc_osx-64 12.*  does not exist (perhaps a typo or a missing channel);
10:15:34 BIOCONDA INFO (ERR) └─ gxx_osx-64 12.*  does not exist (perhaps a typo or a missing channel).

Do you have an idea, how to fix this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem actually concerns #49740 pull request.

git_rev: v{{ version }}

requirements:
build:
- {{ compiler('cxx') }}
- make

test:
commands:
- protestar > /dev/null

about:
home: https://github.com/refresh-bio/protestar
summary: "Protein Structures Archiver"
license: GPL-3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license: GPL-3
license: GPL-3-only

Please use SPDX ids

license_family: GPL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license_family: GPL
license_family: GPL3

license_file: LICENSE

extra:
skip-lints:
- uses_vcs_url
- missing_hash
identifiers:
- doi:https://doi.org/10.1093/bioinformatics/btae428
Loading