-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protestar #47764
Open
agudys
wants to merge
5
commits into
bioconda:master
Choose a base branch
from
agudys:update_protestar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add protestar #47764
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#!/bin/bash | ||
make protestar -j${CPU_COUNT} | ||
install -d "${PREFIX}/bin" | ||
install protestar "${PREFIX}/bin" | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,38 @@ | ||||||
{% set version = "1.1.0" %} | ||||||
|
||||||
|
||||||
package: | ||||||
name: protestar | ||||||
version: {{ version }} | ||||||
|
||||||
build: | ||||||
number: 0 | ||||||
run_exports: | ||||||
- {{ pin_subpackage('protestar', max_pin='x.x.x') }} | ||||||
|
||||||
source: | ||||||
git_url: https://github.com/refresh-bio/protestar.git | ||||||
git_rev: v{{ version }} | ||||||
|
||||||
requirements: | ||||||
build: | ||||||
- {{ compiler('cxx') }} | ||||||
- make | ||||||
|
||||||
test: | ||||||
commands: | ||||||
- protestar > /dev/null | ||||||
|
||||||
about: | ||||||
home: https://github.com/refresh-bio/protestar | ||||||
summary: "Protein Structures Archiver" | ||||||
license: GPL-3 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Please use SPDX ids |
||||||
license_family: GPL | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
license_file: LICENSE | ||||||
|
||||||
extra: | ||||||
skip-lints: | ||||||
- uses_vcs_url | ||||||
- missing_hash | ||||||
identifiers: | ||||||
- doi:https://doi.org/10.1093/bioinformatics/btae428 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you use https://github.com/refresh-bio/protestar/archive/refs/tags/v1.1.0.tar.gz + sha256 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
The reason we have used
git_url
is the presence of submodules, which are not included in release tarballs. However, as protestar developers, we have a full control on version tags, thus we believe usinggit_url
is similarly safe as using releases.We have different problem, though. We use some modern C++ multithreading features that require g++-11 for compilation. Unfortunately, these features are not supported by clang. Therefore, I would like to know if there is some workaround to install g++ in macOS conda environment in order to build a package.
Best Regards,
Adam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be precise, the question about g++ on macOS environment actually concerns some other packages we plan to submit to bioconda, not protestar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could achieve this by using custom
conda_build_config.yaml
with contents like:See https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/a7b5c2d598ef642f911f9a0055ddf92666c6af08/recipe/conda_build_config.yaml for all defaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the response! Unfortunately, I got the following message in macOS environment (I have altered also
c_compiler_version
andcxx_compiler_version
to 12 so it does not search for g++-16):Do you have an idea, how to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem actually concerns #49740 pull request.