-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Snk #51152
Add Snk #51152
Conversation
📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces a new Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/snk/meta.yaml (1)
51-51
: Remove extra blank lines at the end of the file.There are too many blank lines at the end of the file. Please remove the extra blank lines to improve the file's formatting.
Apply this diff to fix the issue:
- -🧰 Tools
🪛 yamllint
[warning] 51-51: too many blank lines
(2 > 0) (empty-lines)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/snk/meta.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
recipes/snk/meta.yaml
[warning] 51-51: too many blank lines
(2 > 0) (empty-lines)
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (6)
recipes/snk/meta.yaml (6)
1-10
: LGTM: Package and source sections are well-defined.The package name and version are correctly defined using Jinja2 variables. The source URL is properly constructed, and the SHA256 checksum is provided for integrity verification.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
12-19
: LGTM: Build section is well-configured.The build section is properly configured:
- The use of
run_exports
withpin_subpackage
helps maintain compatibility.- The entry point for 'snk' is correctly defined.
- The package is appropriately marked as
noarch: python
.- The build script uses the recommended method for installing the package.
31-38
: LGTM: Test section is comprehensive.The test section includes appropriate checks:
- Import check for 'snk'
- Pip check to ensure all dependencies are satisfied
- Command-line help check to verify the entry point is working
- Requirement for pip in the test environment
These tests should help ensure the package is installed and functioning correctly.
40-45
: LGTM: About section is well-defined. Verify license file.The about section provides good metadata about the package, including home and dev URLs, a summary, and license information.
Please verify that the LICENSE.txt file exists in the source package. Run the following script:
#!/bin/bash # Description: Check if LICENSE.txt exists in the source package # Download the source package curl -sLO https://pypi.io/packages/source/s/snk/snk-0.30.1.tar.gz # Extract and check for LICENSE.txt tar -tzf snk-0.30.1.tar.gz | grep -i "license.txt" # Clean up rm snk-0.30.1.tar.gz
47-49
: LGTM: Maintainer is specified. Verify permissions.The recipe maintainer is listed as Wytamma.
Please verify that Wytamma has the necessary permissions to maintain this package in the Bioconda channel. You can check this by running:
21-29
: LGTM: Requirements are well-defined. Verify version constraints.The requirements section is properly structured with both host and run requirements. The Python version requirement is consistent.
Please verify that the version constraints for
gitpython
andsnk-cli
are correct and up-to-date. Run the following script to check the latest versions:✅ Verification successful
Version constraints are up-to-date and appropriate
The current version constraints for GitPython and snk-cli in the meta.yaml file are valid and align with the latest available versions:
- GitPython >=3.1.0,<3.2.dev0: Latest version is 3.1.43, which satisfies this constraint.
- snk-cli >=0.5.2: Latest version is 0.5.2, which exactly matches this constraint.
No updates to the version constraints are necessary at this time.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check latest versions of gitpython and snk-cli on PyPI echo "Latest gitpython version:" curl -s https://pypi.org/pypi/gitpython/json | jq -r '.info.version' echo "Latest snk-cli version:" curl -s https://pypi.org/pypi/snk-cli/json | jq -r '.info.version'Length of output: 229
Script:
#!/bin/bash # Description: Check latest versions of gitpython and snk-cli on PyPI without using jq echo "Latest gitpython version:" curl -s https://pypi.org/pypi/gitpython/json | grep '"version":' | head -1 | sed -E 's/.*"version": "([^"]+)".*/\1/' echo "Latest snk-cli version:" curl -s https://pypi.org/pypi/snk-cli/json | grep '"version":' | head -1 | sed -E 's/.*"version": "([^"]+)".*/\1/'Length of output: 164834
@BiocondaBot please add label |
Add snk to bioconda
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.Summary by CodeRabbit
New Features
snk
version0.30.1
with enhanced metadata.Bug Fixes