Update fmsi recipe #51525
Update fmsi recipe #51525
Conversation
📝 WalkthroughWalkthroughThis pull request introduces updates to the versioning of the Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/fmsi/meta.yaml (1)
Issues Found: Missing ARM64-Specific Code or Build Instructions
The search results show architecture-specific code for Intel64 in
recipes/spydrpick/FindTBB.cmake, but no ARM64 (aarch64) specific code was found. Please ensure that ARM64 compatibility is properly implemented and tested.🔗 Analysis chain
Line range hint
51-51: LGTM: Addition of linux-aarch64 platform is beneficial.The inclusion of the
linux-aarch64platform in theadditional-platformssection is a positive change, as it expands the package's compatibility to ARM64 architecture.To ensure the package is indeed compatible with the ARM64 architecture, please verify that:
- The package has been tested on an ARM64 system.
- Any architecture-specific code or dependencies have been properly handled.
You can use the following script to check for any architecture-specific code or build instructions:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for architecture-specific code or build instructions # Search for architecture-specific keywords in the source code and build files rg -i 'aarch64|arm64|x86_64|x86|intel|amd' --type cpp --type c --type make --type cmakeLength of output: 687
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- recipes/fmsi/0002-version.patch (1 hunks)
- recipes/fmsi/meta.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- recipes/fmsi/0002-version.patch
🧰 Additional context used
🔇 Additional comments (3)
recipes/fmsi/meta.yaml (3)
16-16: LGTM: Build number increment is appropriate.The build number increment from 0 to 1 is correct. This change is consistent with making modifications to the package without changing its version number.
Line range hint
1-51: Summary: Changes look good overall.The changes to the
meta.yamlfile are consistent with the PR objectives and the AI-generated summary. The build number increment and the addition of thelinux-aarch64platform are positive changes. Please ensure to verify the ARM64 compatibility and the version update in the patch file as suggested in the previous comments.
Line range hint
1-51: Verify version update in the patch file.The AI-generated summary mentions that the version number in the
src/versionfile was updated from0.2.2to0.2.4. This change is not directly visible in themeta.yamlfile and is likely handled by the0002-version.patch.Please run the following script to verify the version update in the patch file:
Ensure that the patch file correctly updates the version from 0.2.2 to 0.2.4.
✅ Verification successful
Version update correctly applied in
0002-version.patch.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify version update in the patch file # Check the content of the version patch file cat recipes/fmsi/0002-version.patch # Verify that the patch updates the version from 0.2.2 to 0.2.4 grep -E '[-+]0\.2\.[24]' recipes/fmsi/0002-version.patchLength of output: 241
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.