Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update matchms dependencies #51552

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Update matchms dependencies #51552

merged 4 commits into from
Oct 22, 2024

Conversation

BioGeek
Copy link
Contributor

@BioGeek BioGeek commented Oct 22, 2024

Update matchms dependencies to match those in the pyproject.toml of the project


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Copy link
Contributor

coderabbitai bot commented Oct 22, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request introduces updates to the meta.yaml file for the matchms package. The version number is incremented from 0.27.0 to 0.27.1, and the build number changes from 0 to 1. The Python version requirement has been adjusted from >=3.8,<3.12 to >=3.9,<3.13. Additionally, several dependencies have been updated with specific version constraints. The deprecated package now requires a minimum version of 1.2.14, while lxml, matplotlib-base, networkx, numba, numpy, pyyaml, rdkit, requests, scipy, tqdm, pillow, and pandas have all been updated to reflect new version requirements or exclusions. Notably, the pillow package now explicitly excludes version 9.4.0. There are no changes to the test imports or the about section of the package.

Possibly related PRs

  • Update PhyloAcc recipe #51090: The changes in the meta.yaml file for the PhyloAcc package include updates to the build number and Python version compatibility, which are similar in nature to the updates made in the matchms package's meta.yaml.
  • Update tbtamr dependencies #51140: The tbtamr package's meta.yaml updates include changes to the Python version requirement, which aligns with the modifications made in the matchms package's meta.yaml.
  • Update assembly_finder recipe #51449: The assembly_finder package's meta.yaml updates include changes to the Python version requirement and dependency updates, similar to the changes made in the matchms package's meta.yaml.

Suggested labels

new version


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 63b1db5 and f3c7ece.

📒 Files selected for processing (1)
  • recipes/matchms/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (9)
recipes/matchms/meta.yaml (9)

13-13: LGTM: Build number increment is correct.

Incrementing the build number from 0 to 1 is appropriate when updating dependencies without changing the package version. This change follows conda packaging best practices.


25-30: LGTM: Dependency updates look good.

The updates to dependency versions (deprecated, lxml, matplotlib-base, networkx, numba, numpy) appear to be in line with the PR objectives. These changes likely reflect the latest compatible versions.

To ensure these updates don't introduce compatibility issues, consider running the package's test suite with these new dependency versions.


33-33: LGTM: Python version consistency achieved.

The update to python >=3.9,<3.13 in the run section now matches the host section, resolving the inconsistency noted in the previous review. This change ensures compatibility between the build and runtime environments.


34-37: LGTM: Further dependency updates look good.

The updates to dependency versions (pyyaml, rdkit, requests, scipy) continue to align with the PR objectives. These changes likely reflect the latest compatible versions for the package.


39-39: LGTM: tqdm version update is appropriate.

Specifying a minimum version for tqdm (>=4.65.0) is a good practice. This ensures compatibility with the latest features or bug fixes in the tqdm package.


40-40: Please clarify the pillow version constraint.

The pillow dependency has been changed from =9.5 to !=9.4.0. While excluding a specific version can be valid, it's unclear why this particular version (9.4.0) is being excluded. Could you provide more context on this change?

Is there a known issue with pillow 9.4.0 that necessitates this exclusion? If so, consider adding a comment in the meta.yaml file explaining the reason for this constraint.


41-41: LGTM: pandas version update is appropriate.

Specifying a minimum version for pandas (>=2.0.3) is a good practice. This ensures compatibility with the latest features or bug fixes in the pandas package.


Line range hint 1-70: Summary of review for recipes/matchms/meta.yaml

The changes in this file largely meet the PR objectives of updating dependencies for the matchms package. Key points:

  1. The build number has been correctly incremented.
  2. Python version requirements have been updated and are now consistent between host and run sections.
  3. Most dependency updates look good and align with the goal of using the latest compatible versions.
  4. The change to the pillow dependency requires clarification.

Overall, the changes improve the package's compatibility with newer dependency versions. Once the pillow dependency change is clarified, this update should be ready for merging.


22-22: Verify Python version consistency.

The update to python >=3.9,<3.13 in the host section is good. However, please ensure this change is consistent with the Python version specified in the run section (line 33) to address the previous review comment about version inconsistency.

Run the following script to check for consistency:

✅ Verification successful

Python version requirement is now consistent between host and run sections.
The update to python >=3.9,<3.13 ensures both sections are aligned, addressing the previous inconsistency.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check Python version requirements in recipes/matchms/meta.yaml
rg -i 'python\s*(:|version|=|>=|<=|<|>)' recipes/matchms/meta.yaml

Length of output: 118


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 496918d and 63b1db5.

📒 Files selected for processing (1)
  • recipes/matchms/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (5)
recipes/matchms/meta.yaml (5)

13-13: LGTM: Build number increment is correct.

Incrementing the build number from 0 to 1 is appropriate when making changes to the package without changing the version. This change follows conda-forge best practices.


25-25: Verify specific version requirement for 'deprecated' package.

The deprecated package now requires a minimum version of 1.2.14. Please confirm that this specific version requirement aligns with the upstream project's needs and doesn't introduce any compatibility issues.


30-30: Verify numpy version range expansion.

The numpy package requirement has been changed from <1.25 to >1.22,<1.27. This expands the range of supported numpy versions. Please confirm that this change is intentional and doesn't introduce any compatibility issues with other dependencies or the package itself.


40-40: Clarify pillow version requirement change.

The pillow package requirement has changed from =9.5 to !=9.4.0. This change removes the strict version requirement and only excludes version 9.4.0. Please provide clarification on:

  1. The reason for excluding specifically version 9.4.0.
  2. Why the strict version requirement (=9.5) was removed.
  3. Whether this change aligns with the upstream project's requirements.

25-41: Verify alignment of dependency updates with upstream project.

Several dependencies have been updated with specific version constraints. Please ensure that these changes align with the requirements specified in the upstream project's pyproject.toml or setup.py file.

To verify the dependency versions in the upstream project, you can run:

#!/bin/bash
# Check dependency versions in pyproject.toml or setup.py
rg -i 'dependencies|install_requires' pyproject.toml setup.py

recipes/matchms/meta.yaml Show resolved Hide resolved
@BioGeek
Copy link
Contributor Author

BioGeek commented Oct 22, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Oct 22, 2024
@BioGeek
Copy link
Contributor Author

BioGeek commented Oct 22, 2024

Also pinging @hechth and @maximskorik for review.

@martin-g martin-g merged commit fe9a310 into bioconda:master Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants