genodsp: add linux-aarch64 build #51597
Conversation
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/genodsp/meta.yaml (1)
40-40: Add newline at end of fileAdd a newline character at the end of the file to comply with YAML best practices.
- linux-aarch64 +🧰 Tools
🪛 yamllint
[error] 40-40: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/genodsp/meta.yaml (2 hunks)
🧰 Additional context used
🪛 yamllint
recipes/genodsp/meta.yaml
[error] 40-40: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (3)
recipes/genodsp/meta.yaml (3)
20-21: LGTM: Build configuration changes are appropriateThe build number increment and modified skip condition are correct for adding aarch64 support. The existing
run_exportsconfiguration withmax_pin="x.x"properly handles ABI compatibility.
38-40: LGTM: Platform configuration is correctThe addition of linux-aarch64 as an additional platform aligns with the PR objective.
🧰 Tools
🪛 yamllint
[error] 40-40: no new line character at the end of file
(new-line-at-end-of-file)
Line range hint
11-13: Verify patch compatibility with aarch64The package includes a
stringop-truncation.patch. Please ensure this patch is compatible with the aarch64 architecture.✅ Verification successful
Let me gather more information about the patch file to better understand its contents and purpose.
Patch is architecture-independent and safe to use
The patch is focused on fixing string truncation warnings by replacing
strncpycalls with a safersafe_strncpyimplementation. The changes are:
- Removing hardcoded
gcccompiler in Makefile- Adding a new
safe_strncpyfunction that properly handles null-termination- Replacing all
strncpycalls withsafe_strncpyThe modifications are purely C standard library related and don't contain any architecture-specific code or assembly. The patch will work correctly on aarch64 and all other architectures.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the patch contains any architecture-specific code # Test: Look for architecture-specific patterns in the patch rg -i "x86|amd64|arm|aarch" recipes/genodsp/stringop-truncation.patchLength of output: 71
Script:
#!/bin/bash # Check the contents of the patch file cat recipes/genodsp/stringop-truncation.patch # Also check if the patch file exists ls -l recipes/genodsp/stringop-truncation.patchLength of output: 5755
|
@BiocondaBot please fetch artifacts |
|
Package(s) built are ready for inspection:
Docker image(s) built:
|
LGTM! |
|
@BiocondaBot please fetch artifacts |
|
Package(s) built are ready for inspection:
Docker image(s) built:
|
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.