Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r-cobrar: add aarch64/arm64 builds #51203

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented Oct 7, 2024

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g added aarch64 Related to adding linux-aarch64 support osx-arm64 Related to adding osx-arm64 support labels Oct 7, 2024
Copy link
Contributor

coderabbitai bot commented Oct 7, 2024

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the meta.yaml file for the cobrar package. The key changes include an increment in the build number from 0 to 1. The indentation for the sha256 line under the source section has been corrected, and the rpaths section has been adjusted for proper indentation of the lib/ entry. Additionally, the extra section has been updated to include new entries for additional-platforms, specifying support for linux-aarch64 and osx-arm64. Overall, the structure and content of the file remain consistent with previous versions, with these adjustments aimed at enhancing clarity and platform compatibility.

Possibly related PRs

Suggested labels

please review & merge

Suggested reviewers

  • bgruening

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1bc7f1b and 2b1b579.

📒 Files selected for processing (1)
  • recipes/r-cobrar/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (4)
recipes/r-cobrar/meta.yaml (4)

16-16: LGTM: Build number increment is correct.

The build number has been properly incremented from 0 to 1. This is the correct approach when modifying a recipe without changing the package version, especially when adding support for new architectures.


Line range hint 1-62: Summary: Changes successfully add ARM64 support.

The modifications to this recipe are minimal and focused, successfully adding support for ARM64 architectures (aarch64/arm64) as intended. The key changes include:

  1. Incrementing the build number.
  2. Adding 'linux-aarch64' and 'osx-arm64' to the 'additional-platforms' section.

These changes appropriately extend the package's compatibility without altering its core functionality or dependencies. The recipe update adheres to Bioconda guidelines and achieves the PR's objective.

To ensure a smooth integration, please:

  1. Verify that the indentation fixes mentioned in the AI summary have been correctly applied.
  2. Confirm that the CI/CD pipeline is configured to build and test the package on the newly added ARM64 platforms.

Once these verifications are complete, this update appears ready for merging.

🧰 Tools
🪛 yamllint

[error] 56-56: trailing spaces

(trailing-spaces)


[warning] 63-63: too many blank lines

(1 > 0) (empty-lines)


58-60: LGTM: Addition of ARM64 platforms is correct.

The addition of 'linux-aarch64' and 'osx-arm64' to the 'additional-platforms' section is correct and aligns with the PR objective of adding aarch64/arm64 builds. This change will enable the package to be built for ARM64 architectures on both Linux and macOS.

To ensure that these new platforms are properly recognized by the build system, please verify that the CI/CD pipeline includes jobs for these architectures. You can check this by running:

#!/bin/bash
# Description: Check if CI configuration includes ARM64 builds

# Test: Look for ARM64 related configuration in CI files
echo "Checking for ARM64 build configurations:"
grep -R "aarch64\|arm64" .github/workflows/* .circleci/* .travis.yml 2>/dev/null || echo "No ARM64 configurations found in CI files. Please ensure the build system is set up to use these new platforms."

Line range hint 1-62: Verify indentation fixes.

The AI summary mentions indentation fixes for the sha256 line under the source section and the lib/ entry in the rpaths section. However, these changes are not visible in the provided diff. Please ensure that these indentation fixes have been applied correctly.

To verify the indentation, run the following command:

✅ Verification successful

Indentation Fixes Verified

The sha256 line under the source section and the lib/ entries under the rpaths section are correctly indented as per YAML standards.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check indentation for specific sections in the YAML file

# Test 1: Check indentation of sha256 under source section
echo "Checking sha256 indentation:"
sed -n '/^source:/,/^[^ ]/p' recipes/r-cobrar/meta.yaml | grep sha256

# Test 2: Check indentation of lib/ under rpaths section
echo "Checking lib/ indentation under rpaths:"
sed -n '/^  rpaths:/,/^[^ ]/p' recipes/r-cobrar/meta.yaml | grep lib/

echo "Please verify that the output shows correct indentation for these lines."

Length of output: 1737


Script:

#!/bin/bash
# Description: Check indentation for specific sections in the YAML file

# Test 1: Check indentation of sha256 under the source section
echo "Checking sha256 indentation under the source section:"
sed -n '/^source:/,/^[^ ]/p' recipes/r-cobrar/meta.yaml | grep '^  sha256:'

# Test 2: Check indentation of lib/ under the rpaths section
echo "Checking lib/ indentation under the rpaths section:"
sed -n '/^    rpaths:/,/^[^ ]/p' recipes/r-cobrar/meta.yaml | grep '^      lib/'

echo "Please verify that the output shows correct indentation for these lines."

Length of output: 568


Script:

#!/bin/bash
# Description: Check indentation for specific sections in the YAML file

# Test 1: Check indentation of sha256 under the source section
echo "Checking sha256 indentation under the source section:"
sed -n '/^source:/,/^[^ ]/p' recipes/r-cobrar/meta.yaml | grep '^  sha256:'

# Test 2: Check indentation of lib/ under the rpaths section
echo "Checking lib/ indentation under the rpaths section:"
sed -n '/^  rpaths:/,/^[^ ]/p' recipes/r-cobrar/meta.yaml | grep '^    - lib/'

echo "Please verify that the output shows correct indentation for these lines."

Length of output: 594

🧰 Tools
🪛 yamllint

[error] 56-56: trailing spaces

(trailing-spaces)


[warning] 63-63: too many blank lines

(1 > 0) (empty-lines)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support osx-arm64 Related to adding osx-arm64 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants