Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyslow5: add aarch64/arm64 builds #51105

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented Oct 2, 2024

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Summary by CodeRabbit

  • New Features

    • Support added for additional platforms: Linux (aarch64) and macOS (arm64).
  • Bug Fixes

    • Corrected indentation for sha256, license_file, and summary entries in the configuration.
  • Chores

    • Incremented the build number for the pyslow5 package.
    • Updated host requirements to include setuptools.

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g added aarch64 Related to adding linux-aarch64 support osx-arm64 Related to adding osx-arm64 support labels Oct 2, 2024
Copy link
Contributor

coderabbitai bot commented Oct 2, 2024

📝 Walkthrough

Walkthrough

The pull request modifies the meta.yaml file for the pyslow5 package. Key changes include an increment of the build number from 0 to 1, the addition of a new extra section specifying additional-platforms for linux-aarch64 and osx-arm64, and corrections to the indentation of the sha256, license_file, and summary lines. The overall structure of the file remains unchanged, with no modifications to existing requirements or other metadata.

Changes

File Change Summary
recipes/pyslow5/meta.yaml - Build number updated from 0 to 1
- Added extra: additional-platforms: - linux-aarch64 - osx-arm64
- Corrected indentation for sha256, license_file, and summary lines
- Added setuptools to host requirements

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 631f32e and b26c665.

📒 Files selected for processing (1)
  • recipes/pyslow5/meta.yaml (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • recipes/pyslow5/meta.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@martin-g
Copy link
Contributor Author

martin-g commented Oct 2, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 pyslow5-1.3.0-py310h1c83a3d_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 pyslow5-1.3.0-py311h591056c_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 pyslow5-1.3.0-py312hc1fa7d7_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 pyslow5-1.3.0-py38h2a0cf47_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 pyslow5-1.3.0-py39h5219a86_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
osx-arm64 pyslow5-1.3.0-py310h7ea0e55_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/de77bd83-f80b-42b1-97f8-825219d1eb86/artifacts/0/tmp/artifacts/packages <package name>
osx-arm64 pyslow5-1.3.0-py311h5310799_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/de77bd83-f80b-42b1-97f8-825219d1eb86/artifacts/0/tmp/artifacts/packages <package name>
osx-arm64 pyslow5-1.3.0-py312hceb483e_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/de77bd83-f80b-42b1-97f8-825219d1eb86/artifacts/0/tmp/artifacts/packages <package name>
osx-arm64 pyslow5-1.3.0-py38h660d129_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/de77bd83-f80b-42b1-97f8-825219d1eb86/artifacts/0/tmp/artifacts/packages <package name>
osx-arm64 pyslow5-1.3.0-py39ha73c9ec_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/de77bd83-f80b-42b1-97f8-825219d1eb86/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 pyslow5-1.3.0-py310h6da8451_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/ffb949e4-857f-4542-8a8f-a0d1309c9325/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 pyslow5-1.3.0-py311h320c806_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/ffb949e4-857f-4542-8a8f-a0d1309c9325/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 pyslow5-1.3.0-py312h42af196_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/ffb949e4-857f-4542-8a8f-a0d1309c9325/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 pyslow5-1.3.0-py38h178b8bd_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/ffb949e4-857f-4542-8a8f-a0d1309c9325/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 pyslow5-1.3.0-py39h2351a9e_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/ffb949e4-857f-4542-8a8f-a0d1309c9325/artifacts/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
pyslow5 1.3.0--py310h1c83a3d_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pyslow5:1.3.0--py310h1c83a3d_1.tar.gz | docker load
pyslow5 1.3.0--py311h591056c_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pyslow5:1.3.0--py311h591056c_1.tar.gz | docker load
pyslow5 1.3.0--py312hc1fa7d7_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pyslow5:1.3.0--py312hc1fa7d7_1.tar.gz | docker load
pyslow5 1.3.0--py38h2a0cf47_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pyslow5:1.3.0--py38h2a0cf47_1.tar.gz | docker load
pyslow5 1.3.0--py39h5219a86_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/pyslow5:1.3.0--py39h5219a86_1.tar.gz | docker load

@martin-g
Copy link
Contributor Author

martin-g commented Oct 2, 2024

mgrigorov in 🌐 euler-arm-22 in /tmp/pyslow5 via 🅒 test123 took 10s 
❯ tar xvf pyslow5-1.3.0-py310h6da8451_1.tar.bz2                                                                                                                                                            (test123) 
info/run_exports.json
info/test/run_test.py
info/recipe/build.sh
info/hash_input.json
info/index.json
info/files
info/recipe/meta.yaml.template
info/paths.json
info/recipe/meta.yaml
info/recipe/conda_build_config.yaml
info/about.json
info/licenses/thirdparty/streamvbyte/LICENSE
info/git
lib/python3.10/site-packages/pyslow5.cpython-310-aarch64-linux-gnu.so
lib/python3.10/site-packages/pyslow5-1.3.0.dist-info/direct_url.json
lib/python3.10/site-packages/pyslow5-1.3.0.dist-info/INSTALLER
lib/python3.10/site-packages/pyslow5-1.3.0.dist-info/WHEEL
lib/python3.10/site-packages/pyslow5-1.3.0.dist-info/RECORD
lib/python3.10/site-packages/pyslow5-1.3.0.dist-info/METADATA
lib/python3.10/site-packages/pyslow5-1.3.0.dist-info/REQUESTED
lib/python3.10/site-packages/pyslow5-1.3.0.dist-info/top_level.txt

mgrigorov in 🌐 euler-arm-22 in /tmp/pyslow5 via 🅒 test123 
❯ file lib/python3.10/site-packages/pyslow5.cpython-310-aarch64-linux-gnu.so                                                                                                                               (test123) 
lib/python3.10/site-packages/pyslow5.cpython-310-aarch64-linux-gnu.so: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, with debug_info, not stripped

LGTM!

Trying to solve:
```
try:␛[0m
2024-10-02T13:23:22.4921930Z 13:23:20 ␛[32mBIOCONDA INFO␛[0m (ERR)       import setuptools␛[0m
2024-10-02T13:23:22.4922600Z 13:23:20 ␛[32mBIOCONDA INFO␛[0m (ERR)   except ImportError as error:␛[0m
2024-10-02T13:23:22.4923310Z 13:23:20 ␛[32mBIOCONDA INFO␛[0m (ERR)       print(␛[0m
2024-10-02T13:23:22.4924220Z 13:23:20 ␛[32mBIOCONDA INFO␛[0m (ERR)           "ERROR: Can not execute `setup.py` since setuptools is not available in "␛[0m
2024-10-02T13:23:22.4925070Z 13:23:20 ␛[32mBIOCONDA INFO␛[0m (ERR)           "the build environment.",␛[0m
2024-10-02T13:23:22.4925670Z 13:23:20 ␛[32mBIOCONDA INFO␛[0m (ERR)           file=sys.stderr,␛[0m
2024-10-02T13:23:22.4926240Z 13:23:20 ␛[32mBIOCONDA INFO␛[0m (ERR)       )␛[0m
```
on OSX-64

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Copy link
Contributor Author

martin-g commented Oct 2, 2024

@BiocondaBot please add label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support osx-arm64 Related to adding osx-arm64 support please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants