Enable perl-list-moreutils-xs for linux-aarch64 #51816

dslarm · 2024-10-30T17:49:48Z

Add linux-aarch64 to additional-platforms.

coderabbitai · 2024-10-30T17:56:33Z

📝 Walkthrough

Walkthrough

The pull request modifies the meta.yaml file for the perl-list-moreutils-xs package. It updates the build section by incrementing the number from 2 to 3 and adds a new run_exports entry that utilizes the pin_subpackage function. Additionally, it introduces a new extra section that includes additional-platforms, specifically adding support for linux-aarch64. The rest of the file, including package metadata, source information, requirements, and about section, remains unchanged.

Possibly related PRs

tracs: add aarch64/arm64 builds #50103: This PR modifies the meta.yaml file to add support for linux-aarch64, similar to the changes made in the main PR for perl-list-moreutils-xs.
pyslow5: add aarch64/arm64 builds #51105: This PR also introduces linux-aarch64 support in the meta.yaml file for the pyslow5 package, aligning with the changes in the main PR.
metacache: add linux-aarch64 build #51106: The metacache package's meta.yaml file is updated to include linux-aarch64, which is consistent with the main PR's modifications.
perl-convert-binary-c: add aarch64/arm64 build #51107: This PR adds linux-aarch64 support in the meta.yaml file for the perl-convert-binary-c package, directly relating to the changes in the main PR.
r-cobrar: add aarch64/arm64 builds #51203: The r-cobrar package's meta.yaml file is updated to include linux-aarch64, paralleling the main PR's updates.
gnparser: add aarch64/arm64 builds #51376: This PR introduces linux-aarch64 support in the meta.yaml file for the gnparser package, similar to the main PR's changes.
vcf-validator: add linux-aarch64 build #51425: The vcf-validator package's meta.yaml file is modified to add linux-aarch64, which is in line with the main PR's updates.
pybbi: add linux-aarch64 build #51516: This PR adds linux-aarch64 support in the meta.yaml file for the pybbi package, consistent with the changes in the main PR.
genodsp: add linux-aarch64 build #51597: The genodsp package's meta.yaml file is updated to include linux-aarch64, relating to the changes in the main PR.
d4binding: add aarch64/arm64 builds #51598: This PR modifies the meta.yaml file for the d4binding package to add linux-aarch64, which is directly related to the main PR's modifications.

Suggested labels

please review & merge, aarch64

Suggested reviewers

rpetit3

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between afcb929 and 45b0710.

📒 Files selected for processing (1)

recipes/perl-list-moreutils-xs/meta.yaml (2 hunks)

🧰 Additional context used

🪛 yamllint

recipes/perl-list-moreutils-xs/meta.yaml

[error] 40-40: trailing spaces

(trailing-spaces)

🔇 Additional comments (3)

recipes/perl-list-moreutils-xs/meta.yaml (3)

14-15: LGTM! Build configuration changes look good.

The build number increment and addition of run_exports with appropriate pinning will help maintain ABI compatibility.

37-39: LGTM! Platform addition is correctly implemented.

The addition of linux-aarch64 to additional-platforms is properly structured and aligns with the PR objective.

40-40: Remove trailing spaces.

There are trailing spaces at the end of line 40 that should be removed.

🧰 Tools

🪛 yamllint

[error] 40-40: trailing spaces

(trailing-spaces)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 78b2100 and 27acc32.

📒 Files selected for processing (1)

recipes/perl-list-moreutils-xs/meta.yaml (1 hunks)

🧰 Additional context used

🪛 yamllint

recipes/perl-list-moreutils-xs/meta.yaml

[error] 39-39: trailing spaces

(trailing-spaces)

🔇 Additional comments (1)

recipes/perl-list-moreutils-xs/meta.yaml (1)

36-38: LGTM! Platform support addition looks good.

The addition of linux-aarch64 to additional-platforms is correctly implemented and aligns with the PR objective.

coderabbitai · 2024-10-30T17:56:36Z

recipes/perl-list-moreutils-xs/meta.yaml

+extra:
+  additional-platforms:
+  - linux-aarch64
+


⚠️ Potential issue

Remove trailing spaces on line 39.

There are trailing spaces at the end of line 39 that should be removed.

Apply this diff to fix the trailing spaces:

- +

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

🧰 Tools

🪛 yamllint

[error] 39-39: trailing spaces

(trailing-spaces)

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 63d186b and afcb929.

📒 Files selected for processing (1)

recipes/perl-list-moreutils-xs/meta.yaml (2 hunks)

🧰 Additional context used

🪛 yamllint

recipes/perl-list-moreutils-xs/meta.yaml

[error] 16-16: trailing spaces

(trailing-spaces)

[error] 40-40: trailing spaces

(trailing-spaces)

🔇 Additional comments (3)

recipes/perl-list-moreutils-xs/meta.yaml (3)

14-15: LGTM: Build section changes are appropriate.

The build number increment and run_exports addition with pin_subpackage are correctly implemented.

37-39: LGTM: Platform addition is correctly implemented.

The addition of linux-aarch64 to additional-platforms is properly configured and aligns with the PR objective.

40-40: Trailing space issue already reported.

🧰 Tools

🪛 yamllint

[error] 40-40: trailing spaces

(trailing-spaces)

coderabbitai · 2024-10-30T19:45:30Z

recipes/perl-list-moreutils-xs/meta.yaml

-
+  number: 3
+  run_exports: '{{ pin_subpackage(name,  max_pin="x.x") }}'
+


⚠️ Potential issue

Remove trailing space.

There is a trailing space at the end of line 16 that should be removed.

Apply this diff:

- +

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

🧰 Tools

🪛 yamllint

[error] 16-16: trailing spaces

(trailing-spaces)

dslarm · 2024-10-30T20:02:53Z

@martin-g - could you review this?

Add linux-aarch64 to perl-list-moreutils-xs

27acc32

coderabbitai bot reviewed Oct 30, 2024

View reviewed changes

dslarm added 2 commits October 30, 2024 19:31

bump build number

63d186b

add run_exports per lint request

afcb929

coderabbitai bot reviewed Oct 30, 2024

View reviewed changes

Spacing removed - coderabbit check..

45b0710

martin-g approved these changes Oct 31, 2024

View reviewed changes

martin-g merged commit 8520449 into bioconda:master Oct 31, 2024
6 checks passed

dslarm deleted the perl-list-moreutils-xs-aarch64 branch October 31, 2024 19:20

coderabbitai bot mentioned this pull request Nov 17, 2024

perl-io-compress linux aarch64 support #52152

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable perl-list-moreutils-xs for linux-aarch64 #51816

Enable perl-list-moreutils-xs for linux-aarch64 #51816

dslarm commented Oct 30, 2024

coderabbitai bot commented Oct 30, 2024 •

edited

Loading

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot Oct 30, 2024

coderabbitai bot left a comment

coderabbitai bot Oct 30, 2024

dslarm commented Oct 30, 2024


		number: 3
		run_exports: '{{ pin_subpackage(name, max_pin="x.x") }}'

Enable perl-list-moreutils-xs for linux-aarch64 #51816

Enable perl-list-moreutils-xs for linux-aarch64 #51816

Conversation

dslarm commented Oct 30, 2024

coderabbitai bot commented Oct 30, 2024 • edited Loading

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Oct 30, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Oct 30, 2024

Choose a reason for hiding this comment

dslarm commented Oct 30, 2024

coderabbitai bot commented Oct 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)