Fix: Maxit v11.200 #51356
Fix: Maxit v11.200 #51356
Conversation
Signed-off-by: UENO, M. <eunosium-1128@live.jp>
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@BiocondaBot please add label |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/maxit/meta.yaml (1)
Line range hint
1-85: Consider clarifying build process and updating package description.The changes introduce a new source specifically for Linux x86_64 platforms while maintaining the original source. This approach might have implications:
Build Process: Clarify how the build process differs for Linux x86_64 vs. other platforms. Consider adding comments in the recipe to explain the rationale behind using different sources.
Cross-platform Compatibility: Ensure that using different sources for different platforms doesn't introduce unexpected variations in the final package.
Package Description: Update the
aboutsection to mention the platform-specific builds, if relevant to end-users.Consider adding a comment above the new source URL to explain why a different source is used for Linux x86_64:
# Use pre-built binary for Linux x86_64 to [reason for using pre-built binary] - url: https://github.com/eunos-1128/maxit-binaries/archive/refs/tags/v11.200.tar.gz # [linux and x86_64] sha256: b207c7c6e1b191efc28b1b42459fcf5622367d3d3db767e0b6c4326e8b14a94b # [linux and x86_64]Also, consider updating the
aboutsection to reflect these changes:about: # ... existing content ... description: | MAXIT assists in the processing and curation of macromolecular structure data. MAXIT can: # ... existing description ... Note: For Linux x86_64 platforms, this package uses a pre-built binary to [reason for using pre-built binary].
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/maxit/meta.yaml (1 hunks)
🧰 Additional context used
🔇 Additional comments (2)
recipes/maxit/meta.yaml (2)
24-24: LGTM: Build number increment is correct.Incrementing the build number from 1 to 2 is the right approach when making changes to the package without altering its version. This follows Conda packaging best practices.
20-21: Approve new source, but suggest cleanup and verification.The addition of a new source URL for Linux x86_64 platforms is good. However, to improve clarity:
- Consider removing or commenting out the old source URL and checksum (lines 9-10) if they are no longer needed.
- Ensure that the new binary from GitHub is equivalent to the one previously downloaded from sw-tools.rcsb.org.
To verify the integrity and contents of the new source, run:
Compare the output with the expected contents and checksum.
|
This PR has 300+ commits. It is time to rebase your local Git clone! |
I'll make new branch from next PR. |
|
@martin-g |
I changed to download a big binary to be downloaded from github release when starting build.
Ref: #50918 (comment)
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.