longreadsum: add aarch64/arm64 builds #51121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
added
aarch64
📝 WalkthroughWalkthroughThis pull request involves the deletion of two YAML files related to failed builds for the LongReadSum recipe on Linux and OSX platforms, respectively. Additionally, the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
🔇 Additional comments (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
``` $BUILD_PREFIX/bin/aarch64-conda-linux-gnu-c++ -fvisibility-inlines-hidden -fmessage-length=0 -ftree-vectorize -fPIC -fstack-protector-strong -fno-plt -O3 -pipe -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/longreadsum-1.3.1 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -DNDEBUG -D_FORTIFY_SOURCE=2 -O2 -isystem $PREFIX/include -fPIC -Iinclude -I$PREFIX/include/python3.9 -Iinclude -I$PREFIX/include/python3.9 -c src/fasta_module.cpp -o build/temp.linux-aarch64-cpython-39/src/fasta_module.o -std=c++11 07:14:01 BIOCONDA INFO (OUT) src/fasta_module.cpp:7:10: fatal error: zlib.h: No such file or directory 07:14:01 BIOCONDA INFO (OUT) 7 | #include <zlib.h> 07:14:01 BIOCONDA INFO (OUT) | ^~~~~~~~ ``` Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g
commented
Oct 3, 2024
Should fix the following error on osx-arm64 ``` Traceback (most recent call last):�[0m 07:41:23 �[32mBIOCONDA INFO�[0m (ERR) File "setup.py", line 8, in <module>�[0m 07:41:23 �[32mBIOCONDA INFO�[0m (ERR) import setuptools�[0m 07:41:23 �[32mBIOCONDA INFO�[0m (ERR) ModuleNotFoundError: No module named 'setuptools'�[0m 07:41:24 �[32mBIOCONDA INFO�[0m (OUT) Extracting download�[0m ```
|
@BiocondaBot please fetch artifacts |
1 similar comment
|
@BiocondaBot please fetch artifacts |
|
Package(s) built are ready for inspection:
Docker image(s) built:
|
LGTM! |
|
@BiocondaBot please add label |
This was referenced Oct 3, 2024
Open
This was referenced Oct 4, 2024
Merged
This was referenced Oct 8, 2024
Closed
Merged
This was referenced Oct 16, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.Summary by CodeRabbit
meta.yamlto include new requirements (zlib,setuptools) and support for additional platforms (linux-aarch64,osx-arm64).meta.yamlfile for better clarity.