-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trgt to 1.3.0 #52199
Update trgt to 1.3.0 #52199
Conversation
📝 WalkthroughWalkthroughThis pull request modifies the Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/trgt/meta.yaml (1)
Line range hint
23-24
: Consider removing redundant noarch settingThe
noarch: false
setting is redundant since the package is already platform-specific withskip: true # [not linux64]
.build: number: 0 skip: true # [not linux64] - noarch: false
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/trgt/meta.yaml
(1 hunks)
🔇 Additional comments (2)
recipes/trgt/meta.yaml (2)
2-2
: Verify changelog for breaking changes
Please check the upstream changelog for version 1.3.0 to ensure there are no breaking changes that might affect users.
✅ Verification successful
Based on the release notes obtained from GitHub API, I can now generate the final response:
Version 1.3.0 changes are safe to proceed
The changelog shows minor improvements and a bugfix:
- Refactored plotting code
- New
--max-allele-reads
parameter option - Bugfix for repeat identifiers with commas
These changes are non-breaking and enhance functionality without impacting existing behavior.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for changelog entries or release notes
# Expected results: Find information about changes in 1.3.0
# Check release notes
gh api repos/PacificBiosciences/trgt/releases/tags/v1.3.0 --jq '.body'
# Check for CHANGELOG file
rg -l -i 'changelog|release.*notes' --type md
Length of output: 776
2-3
: Verify version and checksum against upstream release
The version bump and checksum update need verification against the official release.
✅ Verification successful
Version and checksum update verified
The verification confirms:
- Version 1.3.0 exists as a valid release tag in the upstream repository
- The source URL template in meta.yaml correctly resolves to the official release artifact
- The file size (7.27MB) and download URL match the official release on GitHub
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify version and checksum against upstream release
# Expected results:
# - Version 1.3.0 exists as a release tag
# - SHA256 matches the release artifact
# Check if the release tag exists
gh api repos/PacificBiosciences/trgt/releases/tags/v1.3.0 --jq '.tag_name'
# Download and verify checksum
TEMP_DIR=$(mktemp -d)
cd $TEMP_DIR
gh release download v1.3.0 -R PacificBiosciences/trgt -p '*linux-gnu.tar.gz'
echo "25d1e7a67c13cde0ab196ef8061a048f58c5c8b70c4ab9acd31613a6dab8ef1d *trgt-v1.3.0-x86_64-unknown-linux-gnu.tar.gz" | sha256sum -c -
Length of output: 436
Script:
#!/bin/bash
# Let's try a different approach to verify the checksum
# First, let's get the release asset URL and its checksum from GitHub API
gh api repos/PacificBiosciences/trgt/releases/tags/v1.3.0 --jq '.assets[] | select(.name | endswith("linux-gnu.tar.gz")) | {browser_download_url, size}'
# Also verify if this version is mentioned in the recipe's source section
rg -A 5 "source:" recipes/trgt/meta.yaml
Length of output: 608
Update
trgt
: 1.2.0 → 1.3.0recipes/trgt
(click to view/edit other files)@PacificBiosciences
This pull request was automatically generated (see docs).