Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: fixing orientation of ranks in heatmaps #100

Merged
merged 5 commits into from
Oct 18, 2019

Conversation

mortonjt
Copy link
Collaborator

After fixing the ranks orientation in #99 , we forgot to fix the orientation of the inputs into heatmap and paired-heatmaps.

This pull request should fix this. CC @nbokulich

@mortonjt
Copy link
Collaborator Author

In addition, realized that the rank heatmaps look best on double centered input. Now, that command does double centering by default.

Further, it looks like the legends weren't aligned properly.
image

That is now fixed
image

@mortonjt
Copy link
Collaborator Author

A bit of digging was done to reproduce the figures in paper

  1. The previous release was still correct - the ranks need to be column centered, not row centered (this is due to the softmax transform). The soil benchmarks support this.
  2. But for the sake of visualization, it can be useful to row center the data. Below is a scenario is an illustration of what can happen.

image

Basically here, all of the columns are biased, and aren't really comparable. The above plots in the previous post are row centered.

But rather than making this a hard-coded default, I'm adding this as an option, since the paired plots have also been shown to look better when centered

image

@mortonjt
Copy link
Collaborator Author

Merging, then we'll cut a real release.

@mortonjt mortonjt merged commit aeae43f into biocore:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant