Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: transposing ranks for final output. #99

Merged
merged 13 commits into from
Oct 17, 2019
Merged

FIX: transposing ranks for final output. #99

merged 13 commits into from
Oct 17, 2019

Conversation

mortonjt
Copy link
Collaborator

Updating documentation in readme accordingly. Addresses #98

@mortonjt
Copy link
Collaborator Author

This is turning into a large pull request.

The original intent of this PR was to allow for the ranks to be transposed in order to view more easily in excel and spreadsheet programs. To do this, a new q2-transformer needed to be added to transform ranks to metadata (to view in qiime metadata tabulate.

However, during this refactor, it was discovered that the ranks between q2 and the standalone version weren't completely consistent, namely the biases weren't incorporated into the standalone version. Long story short, the previous iterations of the ranks maybe biased after post-processing.
This should now be corrected in the tests.

@mortonjt
Copy link
Collaborator Author

Since there were some post-processing changes to the outputs, a couple of more checks, namely with the cystic fibrosis dataset and the biocrust soils dataset.

Below is the CF dataset, showing that the biplot hasn't changed. Furthermore, the ranks for the microcoleus and pseudomonas rhamnolipids are consistent with what we expect.

image

CHANGELOG.md Outdated Show resolved Hide resolved
@mortonjt
Copy link
Collaborator Author

We're going to merge as soon as these tests finish. Then we'll push out a release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant