Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language Option, Relevance Score, #158

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Language Option, Relevance Score, #158

wants to merge 4 commits into from

Conversation

WagnerJon
Copy link

  • added option to choose the prefered language query in the benchmark_data.yaml
  • added relevance score
  • added test function with reassurance

unsure about the implementation of these things

@WagnerJon
Language + relevance score
193642c 
added option to choose language for benchmarks
added relevance score
@WagnerJon
Merge pull request #1 from WagnerJon/WagnerJon-patch-1
1f8d2f9 
Language + relevance score
@WagnerJon
added language selection
d9c092d 
- added additional language option
@WagnerJon
upload results
9184b97 
upload of newer results
@slobentanzer
Copy link
Contributor

TODO:

  • move end-to-end query generation to query generation only (use method _generate_query)
  • use dedicated query_language parameter in _generate_query() method (remove string engineering from test)
  • check rag_interpretation tests to reuse the evaluation_conversation fixture (contest.py)

@slobentanzer slobentanzer marked this pull request as draft July 24, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WagnerJon @slobentanzer