-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dec 2023 infores updates for Service Provider/BTE #1429
Dec 2023 infores updates for Service Provider/BTE #1429
Conversation
NoteI've been creating and editing wiki pages for the infores entries I'm adding/updating here (see comments in the linked issues). However, I noticed that tursynay appeared to have edited many pages into being a common format. So I've reviewed and edited all of the wiki pages I was working on, trying to match the format tursynay was using. This means removing the licensing info, but this info is still saved in the page history. |
@colleenXu - if you merge the |
using the condensed set of knowledge types
I didn't make guesses for resources that I felt other consortium members would know more about (go, monarchinitiative, rampdb, ncats rare-source, etc)
15681f9
to
186f5f4
Compare
I've added two commits with my best guesses for knowledge-level (out of the condensed set of knowledge-types, see Translator Slack convo) :
@sierra-moxon I tried syncing my fork (this branch and its master) with the current master. But it's not clear to me if the |
@colleenXu - let's set it to "Ready for review" (its currently in "Draft"). |
@sierra-moxon I don't have strong opinions on the knowledge-level guesses I made. If you'd like me to change them, I can... |
based on Matt's view that knowledge-level should reflect the content/underlying source https://github.com/biolink/biolink-model/pull/1429\#discussion_r1427313856
so biothings apis, some embl-ebi apis brought in by service provider based on Matt's view that knowledge-level should reflect the content/underlying source https://github.com/biolink/biolink-model/pull/1429\#discussion_r1427313856
2278dc7
to
2c84c14
Compare
Thanks @colleenXu - this looks great to me - shall we get it in before code freeze tomorrow? |
@sierra-moxon @mbrush Following what Matt Brush said above, I've added a commit so the intermediate apis I reviewed (biothings, embl-ebi apis Service Provider brings in) have knowledge-level terms that reflect the content/underlying sources. I'm marking as-resolved the two biothings semmeddb threads... |
@sierra-moxon I'd like it to get in before code freeze! I notice the "chebi" conversation isn't resolved yet....did you want me to make a change there? |
I see why you did that for ChEBI, thank you and I agree with you. I think at some level, ALL the sources are mixed. When we're able to assign Also, I think this is exactly the kind of feedback we're looking for on this effort -- how easy/hard it is to assign these parameters to full sources vs individual edges. We should add it to the EPC agendas for use next round. For now, I would vote to revert (if for no other reason than to keep ontologies in the infores catalog consistent). |
@sierra-moxon okay, it's changed back now. Is anything else needed? |
perfect! lets merge! |
Still working on this.
Need to discuss with @sierra-moxon when this PR needs to be ready, so these changes can be used in this release cycle.