Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate new AGR API for gene-disease relationships into BTE #260

Closed
colleenXu opened this issue Aug 20, 2021 · 4 comments
Closed

integrate new AGR API for gene-disease relationships into BTE #260

colleenXu opened this issue Aug 20, 2021 · 4 comments
Assignees
Labels
data source On Test Related changes are deployed to Test server x-bte

Comments

@colleenXu
Copy link
Collaborator

Involves:

  • writing SmartAPI yaml with x-bte operations (for gene <-> disease associations)
  • registering the yaml with SmartAPI Registry
  • changing the list of APIs BTE ingests to include this new API
@colleenXu colleenXu self-assigned this Aug 20, 2021
@andrewsu andrewsu changed the title integrate new AGR API into BTE integrate new AGR API for gene-disease relationships into BTE Sep 7, 2021
@mnarayan1 mnarayan1 self-assigned this Jun 29, 2023
@mnarayan1
Copy link
Contributor

I can start working on this issue.

@colleenXu
Copy link
Collaborator Author

colleenXu commented Nov 30, 2023

Current situation

Note for the future: It may be useful to update the BioThings AGR data/parser? It looks like the last updates may be from 2021, based on the /metadata endpoint + source code. And new data like Xenbase was added in 2022 (https://www.alliancegenome.org/about-us), which would involve checking/probably-adding x-bte annotation.


Notes on writing the SmartAPI yaml

@colleenXu
Copy link
Collaborator Author

Because of the bug fix, I was able to test the x-bte annotation locally and confirm that it all worked.

Test query: start with MGI

Start with Gene MGI:109384 (Atf3), based on this operation's example

{
    "message": {
        "query_graph": {
            "nodes": {
                "n0": {
                    "ids": ["MGI:109384"],
                    "categories": ["biolink:Gene"]
                },
                "n1": {
                    "categories": ["biolink:Disease"]
                }
            },
            "edges": {
                "e01": {
                    "subject": "n0",
                    "object": "n1",
                    "predicates": ["biolink:biomarker_for"]
                }
            }
        }
    }
}

Should retrieve this edge linked to prostate cancer (DOID:10283 in original API, MONDO:0008315 in TRAPI)

                "543f7cb2ec69057e885f3a90b50f1705": {
                    "predicate": "biolink:biomarker_for",
                    "subject": "NCBIGene:11910",
                    "object": "MONDO:0008315",
                    "attributes": [],
                    "sources": [
                        {
                            "resource_id": "infores:agrkb",
                            "resource_role": "primary_knowledge_source"
                        },
                        {
                            "resource_id": "infores:biothings-agr",
                            "resource_role": "aggregator_knowledge_source",
                            "upstream_resource_ids": [
                                "infores:agrkb"
                            ]
                        },
                        {
                            "resource_id": "infores:service-provider-trapi",
                            "resource_role": "aggregator_knowledge_source",
                            "upstream_resource_ids": [
                                "infores:biothings-agr"
                            ]
                        }
                    ]
                },

Test query: start with DOID

Start with Disease DOID:10629 (microphthalmia), based on this operation's example

{
    "message": {
        "query_graph": {
            "nodes": {
                "n0": {
                    "ids": ["DOID:10629"],
                    "categories": ["biolink:Disease"]
                },
                "n1": {
                    "categories": ["biolink:Gene"]
                }
            },
            "edges": {
                "e01": {
                    "subject": "n0",
                    "object": "n1",
                    "predicates": ["biolink:condition_associated_with_gene"]
                }
            }
        }
    }
}

Should retrieve this edge linked to CYC3 (SGD:S000000037 in original API, NCBIGene:851192 in TRAPI)

                "37b3244f58abee6b388df2686e2f4571": {
                    "predicate": "biolink:condition_associated_with_gene",
                    "subject": "MONDO:0021129",
                    "object": "NCBIGene:851192",
                    "attributes": [],
                    "sources": [
                        {
                            "resource_id": "infores:agrkb",
                            "resource_role": "primary_knowledge_source"
                        },
                        {
                            "resource_id": "infores:biothings-agr",
                            "resource_role": "aggregator_knowledge_source",
                            "upstream_resource_ids": [
                                "infores:agrkb"
                            ]
                        },
                        {
                            "resource_id": "infores:service-provider-trapi",
                            "resource_role": "aggregator_knowledge_source",
                            "upstream_resource_ids": [
                                "infores:biothings-agr"
                            ]
                        }
                    ]
                },

So I made a PR to add it to BTE's regular use. biothings/bte-server#3

@colleenXu colleenXu added On Dev Related changes are deployed to Dev server On CI Related changes are deployed to CI server and removed On Dev Related changes are deployed to Dev server labels Dec 13, 2023
@tokebe tokebe added On Test Related changes are deployed to Test server and removed On CI Related changes are deployed to CI server labels Dec 20, 2023
@colleenXu
Copy link
Collaborator Author

Closing this issue since the changes have been deployed to Prod with the Feb 2024 release.

I've confirmed that I can query BioThings AGR through BTE prod https://bte.transltr.io/v1/team/Service Provider/query with the examples in #260 (comment) and get the expected response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data source On Test Related changes are deployed to Test server x-bte
Projects
None yet
Development

No branches or pull requests

3 participants