fix: EPERM error on windows installation

[MakakWasTaken]

fix: EPERM error on windows installation

Moved the pull request from here: biomejs/biome#735

[nhedger]

Thanks for reopening here @MakakWasTaken 🙏

[nhedger]

Wondering if we should use storageUri instead of the temp dir to store the copy of the biome binary

The uri of a workspace specific directory in which the extension can store private state. The directory might not exist and creation is up to the extension. However, the parent directory is guaranteed to be existent. The value is undefined when no workspace nor folder has been opened.

https://code.visualstudio.com/api/references/vscode-api#ExtensionContext

[MakakWasTaken]

Wondering if we should use storageUri instead of the temp dir to store the copy of the biome binary

The uri of a workspace specific directory in which the extension can store private state. The directory might not exist and creation is up to the extension. However, the parent directory is guaranteed to be existent. The value is undefined when no workspace nor folder has been opened.

https://code.visualstudio.com/api/references/vscode-api#ExtensionContext

Might be smart, would allow for a workspace-based tmp file.

[MakakWasTaken]

Is there more missing on this PR?

[nhedger]

Hey, I just want to make sure it works as expected on all platforms.

I'll test it this week and hopefully merge it before this weekend.

[MakakWasTaken]

Alright, just wanted to make sure I didn't miss anything.

[nhedger]

Currently, the code will copy the binary no matter where it comes from, but we only want to copy it when it comes from the project's dev dependencies.

Particularly, we do not want to copy the binary when:

• the user is using the bundled biome binary
• the binary has been configured with the lspBin setting
• the binary path has been set with the DEBUG_SERVER_PATH env variable

[MakakWasTaken]

I ended up adding a new property called workspaceDependency to the getServerPath function. An alternative way of doing this could be looking after node_modules/@biomejs or something like that in the path. There is however a possibility of users setting either the lspBin or DEBUG_SERVER_PATH to a path including this, which would mess up the result of the function.

[nhedger]

I was able to confirm it works on macOS.

I'll be checking the other systems shortly.

I've slightly reworded some logs and added a missing await statement to prevent the extension from starting the server before the file is copied over.