Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EPERM error on windows installation #735

Closed
wants to merge 5 commits into from

Conversation

MakakWasTaken
Copy link

Summary

Attempt to fix an EPERM error on installation on windows. This is done by copying the executable from the installed path (node_modules) to the tmpdir.

It also adds a watcher for changes, in order to keep the biome executable in tmp up-to-date.

Proposed fix for biomejs/biome-vscode#8

Test Plan

Tested the project on a local project where it seams to have fixed the problem. (Only tested on one platform)

@ematipico ematipico requested a review from nhedger November 15, 2023 16:58
@nhedger
Copy link
Member

nhedger commented Nov 15, 2023

Hey @MakakWasTaken, thank you for taking a stab at this issue.

Before diving into the code of this PR, I'd like to be able to reproduce this issue personally to understand what is going on entirely.

I took a peek at the code, and I don't think it would work as-is because it doesn't seem to consider operating systems other than Windows (hardcoded .exe, for example).

Also, the file watcher only watches for changes in yarn.lock files, but the end user may use any other package manager. I definitely like this idea, though!

Let's continue the discussion in biomejs/biome-vscode#8 for now.

@nhedger
Copy link
Member

nhedger commented Nov 16, 2023

Could you reopen this PR against https://github.com/biomejs/biome-vscode ?

Development of the VS Code extension has recently moved there, and is slightly out of sync with this repo.

@nhedger
Copy link
Member

nhedger commented Nov 16, 2023

Closed in favor of biomejs/biome-vscode#7

@nhedger nhedger closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants