Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(format/html): reenable snapshot tests #3979

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 18, 2024

Summary

Turns out that the snapshot tests were silently disabled since the 1.9.0 release.

This PR also reorganizes the html snapshot tests to match other languages.

Caution

This PR is stacked on the following PRs. Do not merge it without merging the others and rebasing this branch. To review this PR, look at the last commit only.

Test Plan

Added a panic when a spec test fails to execute.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Formatter Area: formatter L-HTML Language: HTML labels Sep 18, 2024
@dyc3 dyc3 requested review from a team September 18, 2024 21:26
Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #3979 will degrade performances by 7.58%

Comparing 09-18-test_format_html_reenable_snapshot_tests (300b22a) with main (3815905)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 09-18-test_format_html_reenable_snapshot_tests Change
router_17129688031671448157.ts[cached] 2.1 ms 2.2 ms -7.58%

@dyc3 dyc3 marked this pull request as ready for review September 19, 2024 12:10
@dyc3 dyc3 force-pushed the 09-18-test_format_html_reenable_snapshot_tests branch from 4063ead to 300b22a Compare September 19, 2024 12:18
@github-actions github-actions bot removed the A-Project Area: project label Sep 19, 2024
@dyc3
Copy link
Contributor Author

dyc3 commented Sep 19, 2024

I'm gonna go ahead and merge this to unblock some other PRs.

@dyc3 dyc3 merged commit b4d9d9e into main Sep 19, 2024
14 of 15 checks passed
@dyc3 dyc3 deleted the 09-18-test_format_html_reenable_snapshot_tests branch September 19, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Formatter Area: formatter L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant