Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html/formatter): self close tag add slash char #3984

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

suxin2017
Copy link
Contributor

Summary

fix: #3975

Test Plan

add snap test

@github-actions github-actions bot added A-Formatter Area: formatter L-HTML Language: HTML labels Sep 19, 2024
Copy link

codspeed-hq bot commented Sep 19, 2024

CodSpeed Performance Report

Merging #3984 will degrade performances by 7.08%

Comparing suxin2017:feat_self_close_tag_add_slash (096f909) with main (33d0958)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main suxin2017:feat_self_close_tag_add_slash Change
dojo_11880045762646467684.js[cached] 7.9 ms 8.5 ms -7.08%

@suxin2017
Copy link
Contributor Author

@dyc3 How do I trigger the html snapshot test? I modify the snapshot file but the test file is missing updates

@dyc3
Copy link
Contributor

dyc3 commented Sep 19, 2024

The snapshot tests are currently broken, see #3979

@dyc3
Copy link
Contributor

dyc3 commented Sep 19, 2024

I've merged #3979, go ahead and rebase this.

@suxin2017 suxin2017 marked this pull request as ready for review September 20, 2024 07:00
@dyc3 dyc3 merged commit 44b0d16 into biomejs:main Sep 20, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 HTML void tags should always emit a / token
2 participants