Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve new prefix form #1000

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Improve new prefix form #1000

merged 5 commits into from
Nov 27, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Nov 27, 2023

  • Activate the ability to add the contributor email
  • Add field for publications
  • Rename "Repository" to "Source Code Repository" to reduce confusion (people kept putting "bioregistry" as the value for this...)

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (7daea25) 40.89% compared to head (0974a02) 40.82%.

Files Patch % Lines
src/bioregistry/gh/new_prefix.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1000      +/-   ##
==========================================
- Coverage   40.89%   40.82%   -0.07%     
==========================================
  Files         138      138              
  Lines        7916     7928      +12     
  Branches     1845     1847       +2     
==========================================
  Hits         3237     3237              
- Misses       4477     4489      +12     
  Partials      202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthoyt cthoyt merged commit 04466bf into main Nov 27, 2023
11 of 13 checks passed
@cthoyt cthoyt deleted the newer-prefix-form branch November 27, 2023 14:02
cthoyt pushed a commit that referenced this pull request Jan 24, 2024
This PR adds a mapping from the issue template yaml to an internal data
key allowing to process publications submitted as part of the new prefix
request form (which was enabled in
#1000). This should fix
the error in
https://github.com/biopragmatics/bioregistry/actions/runs/7633346253/job/20795375392.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant