-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor? x-bte refactoring: API-level x-bte info #745
Comments
During discussion with @tokebe Jackson today, we agreed:
So we now propose creating an optional My thinking after the discussion today: A. Previously-discussed "API-level" info that could go into that new x-bte field (as optional fields):
B. Here's a rough draft example for the first two kinds of info, using Multiomics Wellness and the field name click to expand
this is a modified snippet of the Multiomics Wellness KP yaml:
C. I'm still unclear on whether the "edge hashing" works for all scenarios. See my "side note" at the bottom of the previous post |
[EDIT: this was the original motivation. The next post explains addressing this and more using a new API-level x-bte field]
This is a less-important + probably-easy part of "x-bte refactoring". Previously brought up #656 (comment) under "idea from @tokebe".
Right now, we have a query-handler config to tell BTE to consider differing edge-attribute values when creating separate edges (during hashing).
This has been helpful for Multiomics KPs, where they may have associations that they want to represent as separate edges, even though they have the same subject-predicate-qualifiers-object (see #407, #647).
However, this would be easier to contribute to and maintain if the config was included in each KP's SmartAPI yaml and imported into BTE with the rest of the x-bte annotation information.
Rough draft of what x-bte may look like
In this rough draft, I'm putting this on an operation-by-operation level since that's how x-bte annotation is mostly set up right now. However, this may act on an API-level...
this is a modified snippet of the Multiomics Wellness KP yaml:
fieldsForUniqueEdges
Side notes: it's unclear to me whether the "consideration of differing edge-attributes"/"edge hash" feature works for KPs that don't use the
edge-attributes
keyword in their x-bte-response-mapping (all Multiomics KPs use theedge-attributes
keyword). I get the sense that that it'd be helpful for other KPs (unresolved "edge-merging" issue with PharmGKB #556 (comment))The text was updated successfully, but these errors were encountered: