-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-bte annotation refactoring discussion #656
Comments
Idea from @tokebe:
Ideas from me:
|
Another idea, although may be more "modifying / adding operations": using list_filter for BioThings APIs more, although that doesn't fully fix reverse-operation issues #316 |
From a convo Jackson and me had today: Some main things to address?
Note:
|
@newgene This is the issue on x-bte refactoring. I heard during today's group meeting that there's some issues with MetaKG stuff and id-prefixes / operation-level source. However, @tokebe and I have discussed the way x-bte annotations are written may be set up 1 way to be more writer-friendly, and be parsed into a different representation for BTE's MetaKG.....because there are diff requirements for both or design ideas. I wonder if this is the case for your Translator/SmartAPI-Registry's MetaKG work....I suspect this work has a different set of requirements from BTE's internal representation AND the x-bte annotation writing... |
One case of "multiple prefixes in output" is #585 |
Jackson @tokebe and I think this is the overarching topic for x-bte refactoring (after reviewing the notes above): The issuesThere seems to be 3 different requirement sets at play, that we want to tell apart and be aware of:
Which leads to specific questions for group discussion, like:
And some ideas on how to "expand" an x-bte operation/ unit of annotationCurrently, 1 x-bte operation represents...
Jackson @tokebe and I have discussed how to make it easier to write x-bte annotation - and one of our ideas is to have 1 x-bte operation (one unit of annotation?) expand to include more info:
my qualifier-set thinking
There are theoretically many operations that would mainly differ by qualifier-set (and how that affects sub-query info like post_filter/filter, jmespath, JQ). The guidance for anatomical / species / and population context qualifiers is currently unclear to me (are they edge-attributes or part of the qualifier-set?). If they turn out to be part of the qualifier-set and we want to suppor them, this has combinatorial explosion problems because the context qualifiers in our KPs have a lot of possible values.
My source field thinking
There are theoretically some operations that would mainly differ by source (and how that affects sub-query info like post_filter/filter, jmespath, JQ...). It would be nice if we could set the source info to field values that are post-processed by BTE... I'm not sure of the scope of this issue though:
Also maybe complicated because some api hits will have multiple source values / fields? |
Going to open this issue as a place-holder for now. Look in comments for discussion on what is involved here
The text was updated successfully, but these errors were encountered: