Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor x-bte refactoring: drop use of useTemplating field #744

Open
colleenXu opened this issue Oct 19, 2023 · 1 comment
Open

minor x-bte refactoring: drop use of useTemplating field #744

colleenXu opened this issue Oct 19, 2023 · 1 comment
Labels
enhancement New feature or request x-bte

Comments

@colleenXu
Copy link
Collaborator

[EDITS will be made to this post as I set up the x-bte refactoring issues.]

This is a less-important + probably-easy part of "x-bte refactoring". Previously brought up here under "remove unneeded fields".


We created the useTemplating field during a past enhancement/refactoring of x-bte annotation.

Features of that past enhancement (that I remember)

While it was useful when first implementing the features + migrating all x-bte annotations over to the new features, now all x-bte annotation has useTemplating: true and uses the features...

So I think we could:

  • make useTemplating: true behavior the default, so it can be removed from x-bte annotation
  • remove useTemplating: false support
  • update all x-bte annotation to remove the useTemplating: true lines
@colleenXu colleenXu added enhancement New feature or request x-bte labels Oct 19, 2023
@colleenXu colleenXu changed the title x-bte refactoring small issue: drop use of useTemplating field minor x-bte refactoring: drop use of useTemplating field Oct 19, 2023
@colleenXu
Copy link
Collaborator Author

colleenXu commented Jan 13, 2025

Currently part of #748 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request x-bte
Projects
None yet
Development

No branches or pull requests

1 participant