Is the protected path (default: ows/proxy) expected to be configurable in the future?

[fderue]

twitcher/twitcher/utils.py

Line 25 in a13dd5d

if parsed_url.path.startswith("/ows/proxy"):

It is currently set to "ows/proxy" so the function "utils.parse_service_name(url)" is working but if we have a different protected_path, it won't. So may I suggest to have something more like:

def parse_service_name(url, protected_path):
    parsed_url = urlparse(url)
    service_name = None
    if parsed_url.path.startswith(protected_path):
        parts_without_protected_path = parsed_url.path[len(protected_path)::].strip('/').split('/')
        if len(parts_without_protected_path) > 0:
            service_name = parts_without_protected_path[0]
    if not service_name:
        raise ServiceNotFound
    return service_name

[cehbrecht]

Making the "protected path" configurable is better than having it hard-coded.

What you like to make a PR?

To configure it you need to update the buildout.cfg and the twitcher.ini template:

• twitcher/buildout.cfg

  Line 42 in a13dd5d

  [settings]

• twitcher/templates/twitcher.ini

  Line 20 in a13dd5d

  # twitcher

[fderue]

Ok I will make a PR, should I do it directly to the master branch or to pingudev?

[cehbrecht]

... PR to master branch. Thanks :)

[cehbrecht]

Fixed by PR #37.