Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make protected_path configurable, by default /ows/proxy #37

Merged

Conversation

fderue
Copy link
Contributor

@fderue fderue commented Mar 13, 2018

Changes

  • The proxy protected path, previously hard coded "/ows/proxy" is now configurable in the settings as
    "ows-proxy-protected-path".
  • Parsing of service_name in utils.py is now adapted to protected_path length

@cehbrecht cehbrecht self-requested a review March 13, 2018 16:02
Copy link
Member

@cehbrecht cehbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because they have no registry.settings. You need to modify the tests. Hope this helps:
https://docs.pylonsproject.org/projects/pyramid/en/latest/api/testing.html#testing-module

def setup_with_mongodb():

@cehbrecht
Copy link
Member

@fderue still something goes wrong in the tests ... haven't figured out. You can try the tests locally:

$ make test
$ make testall    # I think service needs to be started for this with "make start"
$ make pep8

@cehbrecht cehbrecht merged commit b813669 into bird-house:master Mar 14, 2018
@cehbrecht
Copy link
Member

@fderue
looks good ... merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants