-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and Dependencies pre-valiation (branch 0.6.x) #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=========================================
Coverage ? 72.39%
=========================================
Files ? 40
Lines ? 1652
Branches ? 0
=========================================
Hits ? 1196
Misses ? 456
Partials ? 0 Continue to review full report at Codecov.
|
cehbrecht
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is no way to know if something breaks or if the generated Docker image still works when doing a PR.
This PR adds a full test suite using Github Actions to validate that deployed images will work.
Changes
pyramid>=1.10,<2
(<2
is the important part) that was omitted in PRs fix dependencies issues (5.x) #104 / fix dependencies issues (6.x) #105.The
pyramid.compat
modules is removed since v2 and cannot be found when starting Twitcher.(workflow was taken from https://github.com/Ouranosinc/Magpie repo and adjusted/trimmed down for available targets in the current
Makefile
)CHANGES.rst
so links are generated both on Github and ReadTheDocs side.Extra fixes
decode()
withPyJWT>=2
that directly returns strings (issue discovered using above Github test workflow)See also
For branch 0.5.x: #107