Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and Dependencies pre-valiation (branch 0.6.x) #106

Merged
merged 12 commits into from
Aug 27, 2021
Merged

Conversation

fmigneault
Copy link
Member

@fmigneault fmigneault commented Aug 24, 2021

Motivation

There is no way to know if something breaks or if the generated Docker image still works when doing a PR.
This PR adds a full test suite using Github Actions to validate that deployed images will work.

Changes

  • Also apply pyramid>=1.10,<2 (<2 is the important part) that was omitted in PRs fix dependencies issues (5.x) #104 / fix dependencies issues (6.x) #105.
    The pyramid.compat modules is removed since v2 and cannot be found when starting Twitcher.
  • Add Github Action workflow that allows testing (local, lint, docker) to ensure features don't break stuff before PR integration.
    (workflow was taken from https://github.com/Ouranosinc/Magpie repo and adjusted/trimmed down for available targets in the current Makefile)
  • Add Github Templates to help define issues and PR contents in the future.
  • Fix references/format in CHANGES.rst so links are generated both on Github and ReadTheDocs side.

Extra fixes

  • Specific to master / 0.6.x branch: resolve incorrect use of decode() with PyJWT>=2 that directly returns strings (issue discovered using above Github test workflow)

See also

For branch 0.5.x: #107

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@29838fa). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #106   +/-   ##
=========================================
  Coverage          ?   72.39%           
=========================================
  Files             ?       40           
  Lines             ?     1652           
  Branches          ?        0           
=========================================
  Hits              ?     1196           
  Misses            ?      456           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29838fa...f78c945. Read the comment docs.

@fmigneault fmigneault requested a review from cehbrecht August 24, 2021 19:34
@fmigneault fmigneault marked this pull request as ready for review August 24, 2021 19:34
@fmigneault fmigneault self-assigned this Aug 24, 2021
@fmigneault fmigneault changed the title update changelog with fixed links in readthedocs+github Test and Dependencies pre-valiation (branch 0.6.x) Aug 24, 2021
@fmigneault fmigneault merged commit 215169a into master Aug 27, 2021
@fmigneault fmigneault deleted the test-deps branch August 27, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants