Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify main_nav yml #387

Merged
merged 4 commits into from
Aug 18, 2020
Merged

Simplify main_nav yml #387

merged 4 commits into from
Aug 18, 2020

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Aug 10, 2020

This PR simplifies the YML markup for _includes/main_nav.html.

Previously, the main_nav markup was broken into parts and included URLs, which was unnecessary and confusing for translators. These changes condense the main_nav markup into a succinct list.

Review Guidance

A thorough visual review of the main navigation menu should suffice to review this pull request. Visit https://deploy-preview-387--bisq-website.netlify.app/ and make sure the main navigation menu at the top matches what's on https://bisq.network for all 9 languages—desktop and mobile. There should be no missing links, etc. Ideally no colliding text either (e.g., from text that's too long).

m52go added 3 commits August 9, 2020 19:58
YML should be for text-to-be-translated only. Previously, URLs and
items like "_blank" were showing up in Transifex.
@m52go m52go mentioned this pull request Aug 11, 2020
@Bayernatoor
Copy link

Bayernatoor commented Aug 14, 2020

Desktop verison checks out except - see screenshots and note below.
Japanese text showing up wrong on proposed branch
japanese
Main website:
Main-Japanese

Mobile tested on Android 8 and IOS 12

Text looks good, navigation menu looks good.


Desktop and mobile, regardless of language the Getting Started link always redirects the user to the English "Getting Started" page. Perhaps, this hasn't been translated yet?

@m52go
Copy link
Contributor Author

m52go commented Aug 18, 2020

Japanese text showing up wrong on proposed branch

Thanks, good catch. The translation seems to be correct, but the text is too long for the container. The previous translation was shorter, which is why this wasn't happening before. I've reverted this update with b0bf8e8.

Likelihood of this happening in the future should decrease as a result of Transifex notes indicating maximum length for strings like this.

"Getting Started" page. Perhaps, this hasn't been translated yet?

Yup, that's correct.

@m52go m52go merged commit b7d1216 into bisq-network:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants