Simplify dao yml #388
Merged
Simplify dao yml #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 10, 2020 12:31
HTML attributes should not be in <lang>.yml since they cannot be translated.
Done in this pull request to avoid merge conflicts from upcoming copy-update pull request.
|
DAO page, visual review of all 9 languages: Formatting for Japanese text seems incorrect vs English version (master branch also appears this way)
Everything else looks good! 663990a - looks much cleaner then master. a305b2e - text looks good and is a better "why?" then previously. it's appearing on local (en) branch fix-dao-yml |
Nice—HTML tag was missing. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar in spirit to #387, this PR simplifies the YML markup for
_layouts/page_dao.html(the DAO page).Previously, this markup included HTML markup and other artifacts that didn't belong. These suggested changes separate concerns better (keep text-to-be-translated in YML and HTML markup in HTML) and update DAO page copy.
Review Guidance
As with #387, a thorough visual review should be sufficient here too. But since DAO page content is identical on desktop and mobile, there's no need to evaluate mobile rendering separately. Just browse the DAO pages throughout all 9 languages and ensure the text is all there.
Text won't be identical since there were some translation updates...main things to look out for are missing paragraphs, obviously wrong text, broken links, etc.