Add new payment method: Australian PayID #4742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_PayID # Conflicts: # core/src/main/java/bisq/core/proto/CoreProtoResolver.java # proto/src/main/proto/pb.proto
ripcurlx
changed the title
ripcurlx
force-pushed
the
Australian_PayID
branch
from
a55e53c to
0740730
Compare
sqrrm
reviewed
Nov 3, 2020
There was a problem hiding this comment.
I think payid should be considered one word, more like in the original PR. It's pretty confusing with the PAY_ID_ID and as seen on https://payid.com.au/ they treat it like one word, although with odd capitalization.
@ripcurlx I added some suggestions as examples, but if you agree to change this, all the file names and class names and protobuf names also need to change.
core/src/main/java/bisq/core/payment/payload/AustraliaPayIDPayload.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/payment/payload/AustraliaPayIDPayload.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/payment/payload/PaymentMethod.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/payment/payload/PaymentMethod.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/payment/payload/PaymentMethod.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java
Outdated
Show resolved
Hide resolved
ripcurlx
force-pushed
the
Australian_PayID
branch
from
0740730 to
93ee94a
Compare
ripcurlx
force-pushed
the
Australian_PayID
branch
from
93ee94a to
4ecbff8
Compare
|
Superseded by #4743 because of unsigned initial commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4078 for details.
I had to create my own branch as I wasn't able to push to the PR.
Tested it on Regtest and works still with the old test trade on Mainnet.