Add new payment method: Australian PayID #4743
Conversation
|
Please add the an "AUSTRALIA_PAYID" entry in TradeStatistics3.PaymentMethodMapper enum |
| public void setPayID(String payid) | ||
| { | ||
|
|
||
| public void setPayid(String payid) { |
There was a problem hiding this comment.
Our naming convention would be: setPayId and payId
Would require also changes in the protobuf
There was a problem hiding this comment.
I think payid is one word in this case. It's not an id as part of bisq, just the name of the payment method.
There was a problem hiding this comment.
True. They use PayID... anyway not sure whats best here, but also not really important...
There was a problem hiding this comment.
I had it like that before, but I agree with @sqrrm that it is actually a brand name and should be without camelcase in that case.
It was already added by you as there was a live trade on Mainnet by the dev 😉 |
Ah, true ;-) |
See #4078 for details.
I had to create my own branch as I wasn't able to push to the PR and I had to cherry-pick the original commit as it wasn't signed by @mercurytoxic.
Tested it on Regtest and works still with the old test trade on Mainnet.