Improve Chat message reliability #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK from code perspective. @m52go Could you please review the text changes? Thanks! |
m52go
reviewed
Jun 16, 2021
Co-authored-by: m52go <735155+m52go@users.noreply.github.com>
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #5526, there are cases where network messages get the arrived status but no ACK and the receiver never actually saw the message. This can be cause of confusion because the "arrived" status is generally used by the sender as indication that all is good. The ACK is generally ignored.
To remedy this for Chat messages, this PR displays the sent message as "In transit" until the ACK is received back, or it times out and displays status describing the problem and asking the user to try again. The timeout is 5 seconds. An ACK can still be received after 5 seconds, in which case the status will update to show that the message arrived.
Screenshots
Sent the message, waiting for the ACK:
ACK received back:
No ACK received back:
