Fix bug in chat message status display #5599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @huey735 there is a display bug when chat messages are stored in mailbox awaiting peer to come online.
The bug was introduced by #5551
The fix is to consider both acknowledged and stored in mailbox statuses when checking if the message timed out.
To reproduce:
Message saved in receiver's mailbox
.Error: timed out. Try sending message again
. << This is the bug.Expected behavior:
Message saved in receiver's mailbox
.Message saved in receiver's mailbox
.If Bob were to come online Alice's window would update to
Message arrival confirmed by receiver
.