Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in chat message status display #5599

Merged
merged 1 commit into from Jul 6, 2021
Merged

Fix bug in chat message status display #5599

merged 1 commit into from Jul 6, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 2, 2021

Reported by @huey735 there is a display bug when chat messages are stored in mailbox awaiting peer to come online.
The bug was introduced by #5551
The fix is to consider both acknowledged and stored in mailbox statuses when checking if the message timed out.

To reproduce:

  • Alice sends chat message to Bob (who is offline).
  • Alice's chat window shows Message saved in receiver's mailbox.
  • Alice closes chat window, and reopens it again.
  • Alice's chat window now says Error: timed out. Try sending message again. << This is the bug.

Expected behavior:

  • Alice sends chat message to Bob (who is offline).
  • Alice's chat window shows Message saved in receiver's mailbox.
  • Alice closes chat window, and reopens it again.
  • Alice's chat window shows Message saved in receiver's mailbox.

If Bob were to come online Alice's window would update to Message arrival confirmed by receiver.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.7.1 milestone Jul 6, 2021
@ripcurlx ripcurlx merged commit 93df5c2 into bisq-network:master Jul 6, 2021
@ghost ghost mentioned this pull request Jul 18, 2021
@ManoloSFC
Copy link

I'm having that problem, but I'm not getting any answer from the other part after sending multiple messages, so I'm guessing that is not only a problem of Bisq reporting wrongly the status of the message but the message system is actually broken and messages aren't being sent through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants