Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change waiting animation to new design #1209

Closed
HenrikJannsen opened this issue Sep 20, 2023 · 1 comment · Fixed by #1235
Closed

Change waiting animation to new design #1209

HenrikJannsen opened this issue Sep 20, 2023 · 1 comment · Fixed by #1235
Assignees
@axpoems
Labels
good first issue Good for newcomers ui

Comments

@HenrikJannsen
Copy link
Contributor

@pedromvpg delivered those new designs for the waiting animation in the trade state screens.
The ring should be animated. JavaFx has some performance issues with animations (progress indicator takes way too much cpu), so the animation should be implemented with that problem in mind (e.g. a simple rotation of the image might be ok).

image image2

Here are pngs from the screenshots (not great quality, waiting for Pedro to deliver pngs).

animation-circle@2x animation-block@2x animation-file@2x
@HenrikJannsen HenrikJannsen added ui good first issue Good for newcomers labels Sep 20, 2023
@axpoems
Copy link
Contributor

axpoems commented Sep 26, 2023

I can do this.

axpoems added a commit to axpoems/bisq2 that referenced this issue Sep 29, 2023
@axpoems
Introduce new icons for Bisq Easy waiting states
e6e33af 
* Design new icons for all of the waiting states in the Bisq Easy
  protocol.

* Change WaitingAnimation component to use a rotation of a png image
  of a spinning circle instead to improve CPU performace.

* Introduce the different icons into each buyer and seller view states
  accordingly.

Fix bisq-network#1209
@axpoems axpoems mentioned this issue Sep 29, 2023
Merged
axpoems added a commit to axpoems/bisq2 that referenced this issue Sep 30, 2023
@axpoems
Introduce new icons for Bisq Easy waiting states
f9f39e5 
* Design new icons for all of the waiting states in the Bisq Easy
  protocol.

* Change WaitingAnimation component to use a rotation of a png image
  of a spinning circle instead to improve CPU performace.

* Introduce the different icons into each buyer and seller view states
  accordingly.

Fix bisq-network#1209
axpoems added a commit to axpoems/bisq2 that referenced this issue Oct 1, 2023
@axpoems
Introduce new icons for Bisq Easy waiting states
ad7e5ff 
* Design new icons for all of the waiting states in the Bisq Easy
  protocol.

* Change WaitingAnimation component to use a rotation of a png image
  of a spinning circle instead to improve CPU performace.

* Introduce the different icons into each buyer and seller view states
  accordingly.

Fix bisq-network#1209
@axpoems axpoems mentioned this issue Oct 21, 2023
Closed
@axpoems axpoems mentioned this issue Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axpoems axpoems

Labels
good first issue Good for newcomers ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce new icons for Bisq Easy waiting states axpoems/bisq2
2 participants
@HenrikJannsen @axpoems