Introduce new icons for Bisq Easy waiting states #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenrikJannsen
approved these changes
Sep 30, 2023
desktop/src/main/java/bisq/desktop/components/controls/WaitingState.java
Outdated
Show resolved
Hide resolved
axpoems
force-pushed
the
new-waiting-state-icons
branch
from
e6e33af to
f9f39e5
Compare
* Design new icons for all of the waiting states in the Bisq Easy protocol. * Change WaitingAnimation component to use a rotation of a png image of a spinning circle instead to improve CPU performace. * Introduce the different icons into each buyer and seller view states accordingly. Fix bisq-network#1209
axpoems
force-pushed
the
new-waiting-state-icons
branch
from
f9f39e5 to
ad7e5ff
Compare
|
Congrats to your first merged PR in Bisq! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WaitingAnimationcomponent to use a rotation of a png image of a spinning circle instead to improve CPU performance.At the moment,
FIAT_PAYMENTandFIAT_PAYMENT_CONFIRMATIONuse the same icon. I think it works well as is, but will explore that some more.Fix #1209