Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Code style #242

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Code style #242

wants to merge 4 commits into from

Conversation

texhnolyze
Copy link
Contributor

Proposed changes

  • Add black and ruff for Python
  • Add clang-format and cppcheck for C++
  • Add pre-commit configuration and workflow that checks bot

@texhnolyze texhnolyze marked this pull request as draft November 23, 2023 00:56
@texhnolyze
feat(pre-commit): add linting/formating checks
cf04300 
by usage of the [pre-commit](https://pre-commit.com/) framework.
We are including the following:
- `ruff` for fast python linting
- `black` for opinionated python auto formatting
- `clang-format` for C++ formatting based on google styles
- `cppcheck` for C++ linting
@texhnolyze
ci(pre-commit): add github action for linting/formatting
3845495 
that will run and check the pre-commit hooks on PRs and updates on the
master branch
@texhnolyze
style(pre-commit): format all code
7032e31 
with ruff/black for python and cppcheck/clang-format for c++
@texhnolyze
chore(pre-commit): add .git-blame-ignore-revs
e2003b4 
to prevent full repo autoformatting to affect the git history, when
utilizing `git blame`
@jaagut jaagut mentioned this pull request Nov 23, 2023
Closed
@jaagut
Copy link
Member

jaagut commented Nov 23, 2023

Why is this a draft? What's missing?

@jaagut
Copy link
Member

jaagut commented Jan 9, 2024

Ping @texhnolyze

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Flova Flova Awaiting requested review from Flova

@jaagut jaagut Awaiting requested review from jaagut

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Software
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texhnolyze @jaagut