Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alembic DB migrations for NAO elbow joint #52

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Conversation

texhnolyze
Copy link
Contributor

Proposed changes

  • style(ruff): fix vizualization.ipynb
  • feat(db): integrate alembic DB migrations
  • refactor(models): setup consinstent constraint naming
  • feat(migrations): add base dataset migration
  • feat(models): add additional NAO elbow joint

Related issues

Checklist

  • Write documentation
  • Create issues for future work
  • This PR is on our DDLitLab project board

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
as different DBs have very different default naming schemes.
This makes it a lot easier to add/alter/drop constraints, based on their
names with SQL/migrations.
@texhnolyze texhnolyze self-assigned this Jan 23, 2025
@texhnolyze texhnolyze requested review from Flova and jaagut January 23, 2025 16:33
@texhnolyze
Copy link
Contributor Author

Adjusting the gitlab ci is still missing and also clarification if the extra NAO elbow joints are named correctly.

Copy link
Member

@Flova Flova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The NAO seems to have another joint at the wrist. I don't know if it is used tho..
RWristYaw

Verified

This commit was signed with the committer’s verified signature. The key has expired.
BridgeAR Ruben Bridgewater
and its corresponding migration

Verified

This commit was signed with the committer’s verified signature. The key has expired.
BridgeAR Ruben Bridgewater
@texhnolyze texhnolyze force-pushed the feature/alembic-db-migrations branch from 6e5f6df to c829c51 Compare January 30, 2025 10:19

Verified

This commit was signed with the committer’s verified signature. The key has expired.
BridgeAR Ruben Bridgewater
by installing/configuring poetry ourselves with pipx after installing
the python version with the `setup-python` action.
This also requires us to define the poetry cache ourselves, as it is not
handled by `setup-python` anymore.
@texhnolyze texhnolyze force-pushed the feature/alembic-db-migrations branch from dd3ef91 to 2036012 Compare January 30, 2025 11:20
@Flova Flova merged commit 0519e8b into main Jan 30, 2025
5 checks passed
@Flova Flova deleted the feature/alembic-db-migrations branch January 30, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants