Issue with new SSH proxy settings overwriting the default port

[hannes101]

I am testing backintime 1.5.0 for an update in fedora. I noticed that I couldn't ping my local NAS. Checking the logs I found out why.
Please see the settings here:

As you can see, actually it should connect using port 21212, however, when checking the logs, it is using port 22, which is set by the proxy settings.

DEBUG: [common/tools.py:1342 keyringSupported] Found appropriate keyring 'keyring.backends.chainer'
DEBUG: [common/tools.py:1271 keyringSupported] Keyring config file folder: /home/johannes/.config/python_keyring
DEBUG: [common/tools.py:1285 keyringSupported] Available keyring backends:
DEBUG: [common/tools.py:1288 keyringSupported] keyring.backends.fail.Keyring (priority: 0)
DEBUG: [common/tools.py:1288 keyringSupported] keyring.backends.SecretService.Keyring (priority: 5)
DEBUG: [common/tools.py:1288 keyringSupported] keyring.backends.libsecret.Keyring (priority: 4.8)
DEBUG: [common/tools.py:1288 keyringSupported] keyring.backends.chainer.ChainerBackend (priority: 10)
DEBUG: [common/tools.py:1330 keyringSupported] Metaclass keyring.backends.Gnome.Keyring not found: AttributeError("module 'keyring.backends' has no attribute 'Gnome'")
DEBUG: [common/tools.py:1330 keyringSupported] Metaclass keyring.backends.kwallet.Keyring not found: AttributeError("module 'keyring.backends.kwallet' has no attribute 'Keyring'")
DEBUG: [common/tools.py:1330 keyringSupported] Metaclass keyring.backend.SecretServiceKeyring not found: AttributeError("module 'keyring.backend' has no attribute 'SecretServiceKeyring'")
DEBUG: [common/tools.py:1330 keyringSupported] Metaclass keyring.backend.GnomeKeyring not found: AttributeError("module 'keyring.backend' has no attribute 'GnomeKeyring'")
DEBUG: [common/tools.py:1330 keyringSupported] Metaclass keyring.backend.KDEWallet not found: AttributeError("module 'keyring.backend' has no attribute 'KDEWallet'")
DEBUG: [common/tools.py:1339 keyringSupported] Available supported backends: [<class 'keyring.backends.SecretService.Keyring'>, <class 'keyring.backends.kwallet.DBusKeyring'>, <class 'keyring.backends.chainer.ChainerBackend'>]
DEBUG: [common/tools.py:1342 keyringSupported] Found appropriate keyring 'keyring.backends.chainer'
DEBUG: [common/sshtools.py:293 SSH.startSshAgent] ssh-agent already running. Skip starting a new one.
DEBUG: [common/sshtools.py:448 SSH.unlockSshAgent] Private key /home/johannes/.ssh/2019QnapNAS is already unlocked in ssh agent
DEBUG: [common/sshtools.py:725 SSH.checkPingHost] Check ping host "192.168.178.45:22"
DEBUG: [common/sshtools.py:756 SSH.checkPingHost] Ping 192.168.178.45 failed. Host is down or wrong address.

A workaround for that is to enable the proxy settings

and then it connects with the desired port 21212. Please see the attached log file.
backintime_logs.txt

My guess is that it's caused by #1688

[buhtz]

Thank you for testing and reporting. Looks like a candidate for a quick and new release 1.5.1.

[buhtz]

backintime-1.5.1-dev.tar.gz

Should be fixed. I checked it on a VM and my productive machine. Would you like to give it a try with that tarball before I prepare a new release?

[hannes101]

Yes, fixed now with 1.5.1-dev.
backintime_logs.txt

[buhtz]

Thank you very much for testing.

I am assuming that you will do some further tests with your rpm packaging?
Hope not but you might find something else. ☣️ Because of that I will wait with the next release until you give me green light, OK? 🟢

[hannes101]

I am just testing it locally for my personal backup, I think there's not much more I can do now.

[hannes101]

In fedora the package will be in updates-testing for, normally 7 days, I can extend that a bit and we see if things come up.

[buhtz]

Thank you for this offer, but this violates another Deadline. I need to reach Ubuntus DebianPackageFreeze.