Skip to content

Bugfix custom datadir doubleClick - Follow-up #392 #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bugfix custom datadir doubleClick - Follow-up #392 #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/qml/components/StorageLocations.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,28 @@ ColumnLayout {
description: qsTr("Choose the directory and storage device.")
customDir: customDirOption.checked ? fileDialog.folder : ""
checked: optionsModel.dataDir !== optionsModel.getDefaultDataDirString
onClicked: fileDialog.open()
onClicked: {
if (AppMode.isDesktop) {
if (!singleClickTimer.running) {
// Start the timer if it's not already running
singleClickTimer.start();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concept NACK on using a timer here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree wasn't the best approach, let's see if this is still an issue after #427 and #428. I'll close this PR till then.

} else {
// If the timer is running, it's a double-click
singleClickTimer.stop();
}
} else {
fileDialog.open()
}
}
Timer {
id: singleClickTimer
interval: 300
onTriggered: {
// If the timer times out, it's a single-click
fileDialog.open()
}
repeat: false // No need to repeat the timer
}
}
FileDialog {
id: fileDialog
Expand Down
Loading