Network Graph layout - debug window improvement. #291

RandyMcMillan · 2021-04-23T23:03:54Z

Rearrange the views for (imo) better layout and debug window resizing options.

Removing "lblGraphRange" minimumSize enables the view to be reduced to the size of a desktop "widget" :)

https://github.com/bitcoin-core/gui/pull/291/files#diff-a24601363160c5ffd048f45a763e702c988b067f96e48a816c36f855f9820826L681

The peers tab resizes if the detail view is revealed.

Info tab still useful at the "widget" size.

Console tab still functional at "widget" size.

RandyMcMillan · 2021-04-23T23:54:35Z

Tested with #290 #256

https://github.com/RandyMcMillan/gui/commits/net-graph-layout-290-256

RandyMcMillan · 2021-04-24T00:33:28Z

Tested with #271

https://github.com/RandyMcMillan/gui/commits/net-graph-layout-271

Bosch-0 · 2021-04-24T02:16:27Z

tACK 99f6f43 on

Windows 10.

Looks good to me, agree this does look slightly more clean. Other windows seem fine. Before / After screens:

jonatack

Tested Concept ACK. This seems like a nice design improvement.

Suggest reviewers look at the diff with colorMoved = dimmed-zebra and colorMovedWs = allow-indentation-change.

Is the slider working correctly? It seems like I lose the traffic history if I move it. Edit: bug(?) seems to be the same on current master.

jonatack · 2021-04-24T15:51:25Z

src/qt/forms/debugwindow.ui

+ <item>
+ <widget class="QGroupBox" name="groupBox_2">
+ <property name="toolTip">
+ <string extracomment="Totals"/>


How does a user see this tooltip?

thanks - removed

The traffic history always took time to repaint.
I doubt there is an easy fix - it would require caching excessive data in anticipation of a resolution change.
I would lean toward prudent disk space usage over this inconvenience.

Thanks, makes sense and is unrelated to this change. Will re-review tomorrow.

Talkless · 2021-04-25T13:13:17Z

Idunno about Network Info tab. It's now inconsistent with Peers tab, where details are shown on the right.
What if we get more Network metrics in the future, not just received/sent? Keeping right pane allows for future growth.

RandyMcMillan · 2021-04-25T15:13:55Z

there is plenty of room for more tabs. 😄

jonatack · 2021-04-25T16:52:34Z

ACK 1cdcdb3

Talkless · 2021-04-26T17:45:34Z

there is plenty of room for more tabs. smile

What I mean is if there's more data series needed (in addition to "Sent", and "Received") on the same graph, not about new tabs.

jarolrod

tACK 1cdcdb3

Tested on macOS 11.3 Qt 5.15.2. I agree that this is a better use of space.

@RandyMcMillan
You may want to fix your commit author; it's currently authored by git. You may want to change that back to you.

@Talkless

What I mean is if there's more data series needed (in addition to "Sent", and "Received") on the same graph, not about new tabs.

That can be figured out when new data series are proposed

hebasto · 2021-04-30T11:28:01Z

~~Concept ACK.~~ Withdrawn in #291 (comment).

IIUC this is a reincarnation of #90.

$ git log -1
commit 1cdcdb30ce57ab3847a839dcb71570c2c5ef0e36 (HEAD -> pr291-0430)
Author: git <git@gits-Air.deepspace.dynalias.org>
Date:   Mon Sep 14 17:21:44 2020 -0400

    Network Graph layout

^ this (the authorship) should be fixed before merging.

src/qt/forms/debugwindow.ui

hebasto · 2021-04-30T11:58:16Z

horizontalLayout_3 is useless now:

With this change

--- a/src/qt/forms/debugwindow.ui
+++ b/src/qt/forms/debugwindow.ui
@@ -642,9 +642,7 @@
       <attribute name="title">
        <string>&amp;Network Traffic</string>
       </attribute>
-      <layout class="QHBoxLayout" name="horizontalLayout_3">
-       <item>
-        <layout class="QVBoxLayout" name="verticalLayout_4">
+      <layout class="QVBoxLayout" name="verticalLayout_4">
          <item>
           <widget class="TrafficGraphWidget" name="trafficGraph" native="true">
            <property name="sizePolicy">
@@ -867,8 +865,6 @@
            </item>
           </layout>
          </item>
-        </layout>
-       </item>
       </layout>
      </widget>
      <widget class="QWidget" name="tab_peers">

we have

hebasto

~~Approach ACK 0174e68~~ Withdrawn in #291 (comment).

A slider glitching was introduced:

I think the root of this bug is the changed layout of the sldGraphRange, lblGraphRange and btnClearTrafficGraph widgets.

On master:

            <widget class="QLabel" name="lblGraphRange">
             <property name="minimumSize">
              <size>
               <width>100</width>
               <height>0</height>
              </size>
             </property>
             <property name="alignment">
              <set>Qt::AlignCenter</set>
             </property>
            </widget>

This PR:

            <widget class="QLabel" name="lblGraphRange">
            </widget>

RandyMcMillan · 2021-04-30T20:47:38Z

Great catch! In #90 the peers tab toggle detailView wasn't merged yet! So this wasn't an issue.
Re-adding the properties now.

NOTE: I would have reused and rebased PR #90 - For some reason gh wouldn't let me reopen it.

Talkless · 2021-05-03T17:44:39Z

What I mean is if there's more data series needed (in addition to "Sent", and "Received") on the same graph, not about new tabs.

That can be figured out when new data series are proposed

So we gonna move back to the right? :) . Maybe adding a splitter, making right pane collapsible would help if someone wants "full screen like" graph?

RandyMcMillan · 2021-05-05T20:54:15Z

yes @Talkless - that is an option. I will take a look at that.

RandyMcMillan · 2021-05-16T19:35:43Z

Update: 1f373f9

Landscape Layout:

Widget Layout:

RandyMcMillan · 2021-05-16T19:58:10Z

src/qt/forms/debugwindow.ui

 </layout>
 </widget>
 </item>
+ <item>
+ <widget class="QSlider" name="sldGraphRange">
+ <property name="minimumSize">


(re) setting minimum size to address sizing issue when time interval changes

RandyMcMillan · 2021-05-16T19:58:20Z

src/qt/forms/debugwindow.ui

+ </item>
+ <item>
+ <widget class="QLabel" name="lblGraphRange">
+ <property name="minimumSize">


(re) setting minimum size to address sizing issue when time interval changes

RandyMcMillan · 2021-05-16T20:08:48Z

Slider Issue Fixed:

shaavan

Concept ACK
Tested Successfully on Ubuntu 20.04

The New Layout for the Network Traffic Window looks much better than the current master.
It is also not affecting the functionality of other Node Windows.
Nice Work!
The bug discussed here is also fixed. This was done by op by setting a minimum size of 60px for the lblGraphRange.
But I think op should increase the minimum size a little more because it is causing some overflow issues. Adding a screenshot of the problem:

Overflowing of time (in the blue box near the slider)

Other than this the PR seems to work excellently
Adding some screenshots for comparison.

On Maximum Size:

Master	PR

On Minimum Size:

Master	PR

Difference in Layout (Screenshot from Qt Designer):

Master	PR

hebasto · 2021-08-07T12:05:32Z

I've reconsidered my opinion, and withdraw my ACKs (#291 (comment), #291 (review)).

Agree with @Talkless's point (#291 (comment), #291 (comment), #291 (comment)).

One of such changes, that require the current layout, are "Received" and "Send" counters separated by data type: blocks, transactions, addresses, service messages. Especially, this could be helpful with upcoming Erlay protocol (at least for me, of course).

So, for now, Concept NACK from me.

rebroad · 2021-08-25T11:03:36Z

Can we make it so the default is 3 hours not 30 minutes? Or make it so that this can be configured somewhere?

Also, can we make it so that when the time range is changed that the data is not lost?

luke-jr · 2021-10-10T20:52:43Z

src/qt/forms/debugwindow.ui

 <item>
- <layout class="QHBoxLayout" name="horizontalLayout_4">
+ <layout class="QHBoxLayout" name="RecievedBox">


typo here and 2 more

Recieved ==> Received

RandyMcMillan · 2021-11-21T00:40:30Z

Looks good with PR #473 as well...

RandyMcMillan · 2021-11-21T00:42:16Z

Minimum size presentation:

rebroad · 2021-11-24T21:04:34Z

Minimum size presentation:

I like this new format - also, it makes it more possible to add a button above/below reset which could be used to toggle between linear and non-linear (rather than clicking on the graph).

jonatack reviewed Apr 24, 2021

View reviewed changes

RandyMcMillan force-pushed the net-graph-layout branch from 99f6f43 to 1cdcdb3 Compare April 24, 2021 18:04

hebasto added the Design label Apr 25, 2021

jarolrod reviewed Apr 30, 2021

View reviewed changes

hebasto reviewed Apr 30, 2021

View reviewed changes

src/qt/forms/debugwindow.ui Outdated Show resolved Hide resolved

RandyMcMillan force-pushed the net-graph-layout branch from 1cdcdb3 to 0174e68 Compare April 30, 2021 16:44

hebasto reviewed Apr 30, 2021

View reviewed changes

RandyMcMillan force-pushed the net-graph-layout branch from 0174e68 to 99f5026 Compare April 30, 2021 22:04

RandyMcMillan force-pushed the net-graph-layout branch from 99f5026 to 797b1a5 Compare May 16, 2021 19:31

RandyMcMillan force-pushed the net-graph-layout branch 2 times, most recently from 8cc2bba to 1f373f9 Compare May 16, 2021 19:55

RandyMcMillan commented May 16, 2021

View reviewed changes

RandyMcMillan marked this pull request as draft July 22, 2021 17:12

shaavan reviewed Aug 6, 2021

View reviewed changes

luke-jr reviewed Oct 10, 2021

View reviewed changes

RandyMcMillan force-pushed the net-graph-layout branch 2 times, most recently from fef97d9 to f044190 Compare November 14, 2021 18:19

RandyMcMillan force-pushed the net-graph-layout branch 2 times, most recently from a170c84 to 21ed56e Compare November 21, 2021 00:35

Network Graph layout

500841e

RandyMcMillan force-pushed the net-graph-layout branch from 21ed56e to 500841e Compare November 21, 2021 00:37

RandyMcMillan marked this pull request as ready for review November 21, 2021 00:38

RandyMcMillan closed this Dec 14, 2021

bitcoin-core locked and limited conversation to collaborators Dec 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network Graph layout - debug window improvement. #291

Network Graph layout - debug window improvement. #291

RandyMcMillan commented Apr 23, 2021 •

edited

Loading

RandyMcMillan commented Apr 23, 2021

RandyMcMillan commented Apr 24, 2021

Bosch-0 commented Apr 24, 2021

jonatack left a comment •

edited

Loading

jonatack Apr 24, 2021

RandyMcMillan Apr 24, 2021

RandyMcMillan Apr 24, 2021

jonatack Apr 24, 2021

Talkless commented Apr 25, 2021

RandyMcMillan commented Apr 25, 2021

jonatack commented Apr 25, 2021

Talkless commented Apr 26, 2021

jarolrod left a comment

hebasto commented Apr 30, 2021 •

edited

Loading

hebasto commented Apr 30, 2021 •

edited

Loading

hebasto left a comment •

edited

Loading

RandyMcMillan commented Apr 30, 2021

Talkless commented May 3, 2021

RandyMcMillan commented May 5, 2021

RandyMcMillan commented May 16, 2021 •

edited

Loading

RandyMcMillan May 16, 2021

RandyMcMillan May 16, 2021

RandyMcMillan commented May 16, 2021

shaavan left a comment

hebasto commented Aug 7, 2021

rebroad commented Aug 25, 2021

luke-jr Oct 10, 2021

luke-jr Oct 10, 2021

RandyMcMillan commented Nov 21, 2021

RandyMcMillan commented Nov 21, 2021

rebroad commented Nov 24, 2021

Network Graph layout - debug window improvement. #291

Network Graph layout - debug window improvement. #291

Conversation

RandyMcMillan commented Apr 23, 2021 • edited Loading

Rearrange the views for (imo) better layout and debug window resizing options.

RandyMcMillan commented Apr 23, 2021

RandyMcMillan commented Apr 24, 2021

Bosch-0 commented Apr 24, 2021

jonatack left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Talkless commented Apr 25, 2021

RandyMcMillan commented Apr 25, 2021

jonatack commented Apr 25, 2021

Talkless commented Apr 26, 2021

jarolrod left a comment

Choose a reason for hiding this comment

hebasto commented Apr 30, 2021 • edited Loading

hebasto commented Apr 30, 2021 • edited Loading

hebasto left a comment • edited Loading

Choose a reason for hiding this comment

RandyMcMillan commented Apr 30, 2021

Talkless commented May 3, 2021

RandyMcMillan commented May 5, 2021

RandyMcMillan commented May 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RandyMcMillan commented May 16, 2021

shaavan left a comment

Choose a reason for hiding this comment

hebasto commented Aug 7, 2021

rebroad commented Aug 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RandyMcMillan commented Nov 21, 2021

RandyMcMillan commented Nov 21, 2021

rebroad commented Nov 24, 2021

RandyMcMillan commented Apr 23, 2021 •

edited

Loading

jonatack left a comment •

edited

Loading

hebasto commented Apr 30, 2021 •

edited

Loading

hebasto commented Apr 30, 2021 •

edited

Loading

hebasto left a comment •

edited

Loading

RandyMcMillan commented May 16, 2021 •

edited

Loading