Enlarge Network Traffic Graph #90

RandyMcMillan · 2020-09-14T21:52:16Z

This minor GUI change allows for a larger display of the Network Graph.

Before/master:

After/PR:

Before/master:

After/PR:

I capitalized "Window" in the title per standard "Human Interface Guidelines" and common sense.

I added some accessibility settings as part of an on going personal effort to make the GUI more user friendly for impaired users.

hebasto · 2020-09-15T06:47:22Z

@RandyMcMillan

This minor GUI change allows for a larger display of the Network Graph.

On master one can maximize the "Node window" with activated "Network Traffic" at will. How this PR changes that behavior?

I added some accessibility settings as part of an on going personal effort to make the GUI more user friendly for impaired users.

These changes seem unrelated to the PR goal, no?

RandyMcMillan · 2020-09-18T20:29:36Z

@hebasto - this change has to do with better use of space within the confines of the tab itself.

As you can see - there is a lot of unused space in the presentation...

This change simply emphasizes the graph and minimizes the drab gray currently occupying a 1/4 of this tabs real estate...

hebasto · 2020-09-18T20:58:06Z

Concept ACK on reordering child widgets.

@RandyMcMillan Could you place a screenshot "before/master" in the OP to visually compare with the screenshot of "after/PR"?

RandyMcMillan · 2020-09-20T06:07:28Z

Before and After added above.

@hebasto - I am currently using

Qt Creator 4.13.0
Based on Qt 5.15.0 (Clang 11.0 (Apple), 64 bit)

Built on Aug 25 2020 10:08:56

I noticed the window icon isn't included when building on macOS.
It appears to be a bug in QT for macOS and hasn't been removed in this PR.

luke-jr · 2020-10-24T20:05:28Z

src/qt/forms/debugwindow.ui

+    <width>777</width>
+    <height>475</height>
   </rect>
  </property>
  <property name="windowTitle">
-   <string>Node window</string>
+   <string>Node Window</string>


Please leave these alone

luke-jr · 2020-10-24T20:05:46Z

src/qt/forms/debugwindow.ui

@@ -36,7 +36,7 @@
   <item>
    <widget class="QTabWidget" name="tabWidget">
     <property name="currentIndex">
-      <number>0</number>
+      <number>2</number>


No need to change this

jarolrod · 2020-11-05T05:31:46Z

src/qt/forms/debugwindow.ui

@@ -1074,8 +1087,8 @@
               <rect>
                <x>0</x>
                <y>0</y>
-                <width>300</width>
-                <height>426</height>
+                <width>274</width>


why are you including changes to tab_peers in this? While the peers tab should be redesigned to maximize space, I don't think this PR (focused on the network traffic graph) should carry any changes to tab_peers

RandyMcMillan · 2020-11-07T20:14:11Z

rebased to a commit with the current gui ci configurations

jarolrod

Tested ACK 5036d9a. Built and visually verified on Arch Linux (Kernel 5.8.16) and macOS 10.15.7 both with Qt 5.15. Everything looks good to me.

luke-jr · 2020-11-19T16:01:13Z

@RandyMcMillan you thumbs-up'd my review comments, but didn't fix them? O.o

luke-jr · 2020-11-20T16:55:55Z

Why did you rebase this? Please undo... git reset --hard 7a05be5e47d and force-push.

luke-jr · 2020-11-25T15:17:12Z

src/qt/forms/debugwindow.ui

+                <item>
+                 <widget class="QLabel" name="label_24">
+                  <property name="accessibleName">
+                   <string>Recieved</string>


Suggested change

<string>Recieved</string>

<string>Received</string>

Thank you - I value your input.

luke-jr · 2020-11-25T15:17:23Z

src/qt/forms/debugwindow.ui

+                   <string>Recieved</string>
+                  </property>
+                  <property name="accessibleDescription">
+                   <string>Recieved</string>


Suggested change

<string>Recieved</string>

<string>Received</string>

luke-jr · 2020-11-25T15:17:44Z

src/qt/forms/debugwindow.ui

+                   </size>
+                  </property>
+                  <property name="accessibleName">
+                   <string>Bytes Recieved</string>


Suggested change

<string>Bytes Recieved</string>

<string>Bytes Received</string>

RandyMcMillan · 2020-11-29T08:24:34Z

@luke-jr
The CI timed out. It passes on my travis-ci account.
Please restart.
Thanks

luke-jr · 2020-11-30T02:32:42Z

I don't know how to restart CI on this GUI repo... but presumably if you fix those misspellings, it will re-run... (please don't rebase in the process)

RandyMcMillan · 2020-12-05T17:14:04Z

@luke-jr

I realized that I can trigger my own rebuilds after I posted. Really useful.

Also: I noticed codespell ignores the /forms folder and test/lint/lint-qt.sh
is quite limited. There seems to be room for improvement in qt linting.
Worthwhile work?

luke-jr · 2020-12-05T17:15:57Z

I only noticed the misspellings because the linter caught them...

luke-jr · 2020-12-06T19:33:36Z

Again, please don't rebase unless necessary...

git reset --hard 334f0961de8

RandyMcMillan · 2020-12-06T19:42:13Z

This PR wasn't passing CI.
All my other PRs are based on 81d5af4 and pass CI with no conflicts.
Help me understand why this PR should stay on a failing commit?
I always welcome feedback - thanks! :)

hebasto · 2020-12-07T16:42:53Z

This PR wasn't passing CI.

Seem all is ok :)

hebasto

I have reviewed the code (8b79225), and tested it.

I think that adding accessibleName and accessibleDescription properties is out of scope of this PR, and they should be removed.

maflcko changed the title ~~gui: Enlarge Network Traffic Graph~~ Enlarge Network Traffic Graph Sep 20, 2020

luke-jr suggested changes Oct 24, 2020

View reviewed changes

RandyMcMillan mentioned this pull request Oct 25, 2020

WIP: mempool stats chart #108

Closed

4 tasks

jarolrod suggested changes Nov 5, 2020

View reviewed changes

jarolrod approved these changes Nov 12, 2020

View reviewed changes

luke-jr suggested changes Nov 25, 2020

View reviewed changes

Enlarge Network Traffic Graph

8b79225

hebasto requested changes Dec 25, 2020

View reviewed changes

RandyMcMillan marked this pull request as draft January 23, 2021 00:14

RandyMcMillan closed this Jan 23, 2021

hebasto mentioned this pull request Apr 30, 2021

Network Graph layout - debug window improvement. #291

Closed

bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enlarge Network Traffic Graph #90

Enlarge Network Traffic Graph #90

RandyMcMillan commented Sep 14, 2020 •

edited

Loading

hebasto commented Sep 15, 2020

RandyMcMillan commented Sep 18, 2020

hebasto commented Sep 18, 2020

RandyMcMillan commented Sep 20, 2020 •

edited

Loading

luke-jr Oct 24, 2020

luke-jr Oct 24, 2020

jarolrod Nov 5, 2020

RandyMcMillan commented Nov 7, 2020

jarolrod left a comment

luke-jr commented Nov 19, 2020

luke-jr commented Nov 20, 2020

luke-jr Nov 25, 2020

RandyMcMillan Dec 5, 2020

luke-jr Nov 25, 2020

luke-jr Nov 25, 2020

RandyMcMillan commented Nov 29, 2020

luke-jr commented Nov 30, 2020 •

edited

Loading

RandyMcMillan commented Dec 5, 2020

luke-jr commented Dec 5, 2020

luke-jr commented Dec 6, 2020

RandyMcMillan commented Dec 6, 2020 •

edited

Loading

hebasto commented Dec 7, 2020

hebasto left a comment

	<string>Bytes Recieved</string>
	<string>Bytes Received</string>

Enlarge Network Traffic Graph #90

Enlarge Network Traffic Graph #90

Conversation

RandyMcMillan commented Sep 14, 2020 • edited Loading

hebasto commented Sep 15, 2020

RandyMcMillan commented Sep 18, 2020

hebasto commented Sep 18, 2020

RandyMcMillan commented Sep 20, 2020 • edited Loading

luke-jr Oct 24, 2020

Choose a reason for hiding this comment

luke-jr Oct 24, 2020

Choose a reason for hiding this comment

jarolrod Nov 5, 2020

Choose a reason for hiding this comment

RandyMcMillan commented Nov 7, 2020

jarolrod left a comment

Choose a reason for hiding this comment

luke-jr commented Nov 19, 2020

luke-jr commented Nov 20, 2020

luke-jr Nov 25, 2020

Choose a reason for hiding this comment

RandyMcMillan Dec 5, 2020

Choose a reason for hiding this comment

luke-jr Nov 25, 2020

Choose a reason for hiding this comment

luke-jr Nov 25, 2020

Choose a reason for hiding this comment

RandyMcMillan commented Nov 29, 2020

luke-jr commented Nov 30, 2020 • edited Loading

RandyMcMillan commented Dec 5, 2020

luke-jr commented Dec 5, 2020

luke-jr commented Dec 6, 2020

RandyMcMillan commented Dec 6, 2020 • edited Loading

hebasto commented Dec 7, 2020

hebasto left a comment

Choose a reason for hiding this comment

RandyMcMillan commented Sep 14, 2020 •

edited

Loading

RandyMcMillan commented Sep 20, 2020 •

edited

Loading

luke-jr commented Nov 30, 2020 •

edited

Loading

RandyMcMillan commented Dec 6, 2020 •

edited

Loading