WIP: translate strings (#288) #292
Conversation
|
The PR description in #287 looks like helpful guidance for this. (PS - don't put @-prefixed usernames in commits and PR descriptions; the latter because usernames in the description are copied into the merge commit by the merge script. This can cause endless annoying notifications for those concerned. An update to the merge script now warns maintainers if a merge message contains a @username, but it's better not to add them to begin with. For more, see https://jonatack.github.io/articles/how-to-contribute-pull-requests-to-bitcoin-core#pr-descriptions.) |
|
Thanks for working on this!
Indeed, for cases in this PR the translator comments should be used. To ensure, that they are working properly, you could use Also for such changes I'd prefer a pr with a wide scope :) |
| return strList.join(" & "); | ||
| else | ||
| return QObject::tr("None"); | ||
| return QObject::tr("None", "absence of value"); |
There was a problem hiding this comment.
Our goal is to replace useless (in most cases) disambiguation strings (the second argument in tr call) with translator comments:
| return QObject::tr("None", "absence of value"); | |
| //: Absence of value. | |
| return QObject::tr("None"); |
|
NOTE: Currently I am just trying to get an idea of how much work needs to be done. |
|
In its current state this PR does not follow our the most recent translation policy, as we are not using the second argument of the #311 is a good example of the mentioned approach. Closing for now. |
3 participants
Some guidance on this would be appreciated until I get comfortable with this.