Peers Window rename 'Peer id' to 'Peer' #311

jarolrod · 2021-05-03T05:35:24Z

Picking up #290

Original PR Description:

renames the peers tab column header from Peer Id to Peer to allow resizing the column more tightly (this will be particularly useful after Save/restore column sizes of the tables in the Peers tab #256) and does the same for the peer details area.

While here, we also add Qt translator comments for the Peer Table columns.

Master	PR

hebasto · 2021-05-03T21:26:36Z

@jarolrod

Did you consider how it will look on a long-running node when one-digit id peer is next to, say, four-digit id one?

jarolrod · 2021-05-04T16:26:59Z

@hebasto Actually, that's a good point. As a tabular figure, perhaps it makes more sense to leave as-is. Especially, if we enforce a monospace font at some point

to allow resizing the column more tightly

jarolrod · 2021-05-05T08:11:08Z

Update from 4ed95c0 -> 73a91c6

Changes:

Keep Peer # left-aligned as this is more appropriate for a tabular figure

hebasto · 2021-05-09T17:22:13Z

renames the peers tab column header from Peer Id to Peer to allow resizing the column more tightly

If saving of the horizontal space is the motivation, leaving just "ID" or "id" is strictly better approach for the following reasons:

the translated "Peer" could become much longer, e.g., the both variants in Ukrainian are "Вузол" or "З'єднання"
"ID"/"id" is shorter, and often remains untranslated

Also, #290 (comment)

jonatack · 2021-05-10T22:07:55Z

Did you consider how it will look on a long-running node when one-digit id peer is next to, say, four-digit id one?

I considered it carefully and described some of that process in the parent PR description: "center-aligns the entries in the Peer column to align them under the column header rather than to the left (I also tried right-alignment but the values are unreadably close to the Address values and it seems more esthetic to be aligned under the header)."

Ideally they would be right-justified like in -netinfo. Center is still ok and under the header. Left for numbers doesn't make sense to me.

jonatack · 2021-05-10T22:22:57Z

leaving just "ID" or "id" is strictly better approach

Hm, I disagree for the reasons I already described in the parent PR.

For laypeople (not devs or database people), the right word here is probably "number", "peer number" or just "peer", as "number" is self-understood. Of those three, peer is the shortest, and shorter than 4 characters doesn't make sense to consider as these peer numbers don't take long to reach 5+ digits anyway.

"ID" means "identification" and in common use, your ID card. "Show me some ID" is what the police officer or the security guard would ask you.

"Id" is a word from Freudian psychology IIRC.

Maybe a good solution is to have native speakers of each language decide on the best word for that language, and in cases where the English-as-a-first-language and English-as-a-second-language-or-as-dev-jargon differ, provide helpful translation hints in the translator comments.

hebasto · 2021-05-10T22:30:28Z

Maybe a good solution is to have native speakers of each language decide on the best word for that language, and in cases where the English-as-a-first-language and English-as-a-second-language-or-as-dev-jargon differ, provide helpful translation hints in the translator comments.

Agree!

RandyMcMillan · 2021-05-11T04:36:00Z

№ - numero will work..

https://en.wikipedia.org/wiki/Numero_sign

https://github.com/RandyMcMillan/gui/tree/numero-column-name

RandyMcMillan@23dbd90#diff-3fcbd1d49f399ac9b4656011ea03e7ef80a855482d6de33855e6326ec065321fR77

jonatack · 2021-05-11T06:08:11Z

№ - numero will work..

https://en.wikipedia.org/wiki/Numero_sign

Interesting, it is a standard abbreviation in French, TIL it exists in English. I like it better than ID, not sure how well known it is and what the GUI policy is regarding signs/symbols/abbreviations.

hebasto · 2021-05-12T16:16:26Z

Agree to use any neutral replacement for "id" string, even just "#" for English locale :)
https://en.wikipedia.org/wiki/Number_sign

jonatack · 2021-05-12T16:25:55Z

These column headers are words, so for the English I would suggest using "Peer" and then describe alternatives ("This column means the peer number or ID") for translators in the tr comment.

hebasto · 2021-05-12T17:02:01Z

It seem this PR needs translation comments only :)

promag · 2021-05-12T17:07:50Z

Honest opinion here, could be empty. Otherwise ID or # LGTM.

RandyMcMillan · 2021-05-12T18:15:47Z

In this old PR #135 "ID" looked ok...

jarolrod · 2021-05-22T03:00:37Z

Updated from 73a91c6 -> b405f19 (pr311.02, pr311.03, diff)

Changes:

added translator comments for the columns of the Peers Table to address this comment. Hopefully, this translator comment is enough to guide the translation of the term and can appease all sides on the debate of ID vs Peer

hebasto

ACK b405f19, I agree on column title renaming, and as a translator I'm happy to see more translator comments.

I'm not an expert in the English Grammar, therefore, the following nits could be just ignored.

hebasto · 2021-05-25T21:24:18Z

src/qt/peertablemodel.h

+            unique number used to identify a connection. */
+        tr("Peer"),
+        /*: Title of Peers Table column which contains the
+            IP/Onion/I2P address we used to connect to the peer. */


"we used to connect to the peer" -- looks like it is about outgoing connections only.

what do you think about this rephrasing:
Title of the Peers Table column which contains the IP/Onion/I2P address of the connected peer

"column for the peer address" ?

(reviewing from my phone so apologies if a bit out of context)

hebasto · 2021-05-25T21:25:13Z

src/qt/peertablemodel.h

+        /*: Title of Peers Table column which contains a value for
+            the type of connection we have established with the peer.


"a value for the type" -- sounds unusual for me.

agree that "we have established" sounds like outbound

"which describes the type of peer connection" ?

hebasto · 2021-05-25T21:25:39Z

src/qt/peertablemodel.h

+        /*: Title of Peers Table column which contains a value for
+            the network the peer resides on. */


"a value for the network" -- sounds unusual for me.

"column for the network the peer connected through" ?

hebasto · 2021-05-25T21:26:43Z

src/qt/peertablemodel.h

+            the latency of the connection established with the peer. */
+        tr("Ping"),
+        /*: Title of Peers Table column which contains a value for
+            the total amount of bytes we have sent to the peer. */


"bytes" -- could the exact name of the unit be avoided? (two places)

hebasto · 2021-05-25T21:29:55Z

src/qt/peertablemodel.h

+        tr("Received"),
+        /*: Title of Peers Table column which contains the peer's
+            User Agent string. A peer can configure this value to
+            allow itself to be identifiable. */


I assume there could be more reasons to use -uacomment, maybe avoid this particular pattern to make the comment more general?

Adds Qt Translator Comments to each Peers Table column to aid translators by providing context.

jarolrod · 2021-05-26T01:16:38Z

updated from b405f19 -> 657b33e (pr311.03, pr311.04, diff)

Changes:
Updated to address review comments on the translator comment contents, thanks @hebasto and @jonatack!

Here is a diff of how I've taken your suggestions and updated from pr311.03:

diff --git a/src/qt/peertablemodel.h b/src/qt/peertablemodel.h
index 268ae013e..3d195342f 100644
--- a/src/qt/peertablemodel.h
+++ b/src/qt/peertablemodel.h
@@ -79,27 +79,25 @@ private:
             unique number used to identify a connection. */
         tr("Peer"),
         /*: Title of Peers Table column which contains the
-            IP/Onion/I2P address we used to connect to the peer. */
+            IP/Onion/I2P address of the connected peer. */
         tr("Address"),
-        /*: Title of Peers Table column which contains a value for
-            the type of connection we have established with the peer.
-            Type is a term denoting what the connection is for. */
+        /*: Title of Peers Table column which describes the type of
+            peer connection. The "type" describes why the connection exists. */
         tr("Type"),
-        /*: Title of Peers Table column which contains a value for
-            the network the peer resides on. */
+        /*: Title of Peers Table column which states the network the peer
+            connected through. */
         tr("Network"),
-        /*: Title of Peers Table column which contains a value for
-            the latency of the connection established with the peer. */
+        /*: Title of Peers Table column which indicates the current latency
+            of the connection with the peer. */
         tr("Ping"),
-        /*: Title of Peers Table column which contains a value for
-            the total amount of bytes we have sent to the peer. */
+        /*: Title of Peers Table column which indicates the total amount of
+            network information we have sent to the peer. */
         tr("Sent"),
-        /*: Title of Peers Table column which contains a value for
-            the total amount of bytes we have received from the peer. */
+        /*: Title of Peers Table column which indicates the total amount of
+            network information we have received from the peer. */
         tr("Received"),
         /*: Title of Peers Table column which contains the peer's
-            User Agent string. A peer can configure this value to
-            allow itself to be identifiable. */
+            User Agent string. */
         tr("User Agent")};
     std::unique_ptr<PeerTablePriv> priv;
     QTimer *timer;

jonatack · 2021-05-26T13:15:53Z

utACK 657b33e

hebasto

re-ACK 657b33e

657b33e qt: add translator comments for peers table columns (Jarol Rodriguez) 73a91c6 gui: rename "Peer Id" to "Peer" in tab column and details area (Jon Atack) Pull request description: Picking up bitcoin-core/gui#290 **Original PR Description:** - renames the peers tab column header from `Peer Id` to `Peer` to allow resizing the column more tightly (this will be particularly useful after #256) and does the same for the peer details area. While here, we also add Qt translator comments for the Peer Table columns. | Master | PR | | ----------- | ----------- | | ![Screen Shot 2021-05-03 at 1 23 05 AM](https://user-images.githubusercontent.com/23396902/116843818-20a14b00-abaf-11eb-913e-ddff11cda5cd.png) | ![Screen Shot 2021-05-05 at 4 08 45 AM](https://user-images.githubusercontent.com/23396902/117112825-a2cc7380-ad57-11eb-939b-1aceb4214ad1.png) | ACKs for top commit: jonatack: utACK 657b33e hebasto: re-ACK 657b33e Tree-SHA512: f50116f7ca8719cadf1f95f45e3594b3b92bde9c43eb954f3e963ed10629dd9406efdb5e96aa1f750a926e24a96321d824ed3780bd9cd748774e0b85fd0c9535

gui: rename "Peer Id" to "Peer" in tab column and details area

73a91c6

to allow resizing the column more tightly

jarolrod force-pushed the peer_id_improv branch from 4ed95c0 to 73a91c6 Compare May 5, 2021 08:07

jarolrod changed the title ~~Peers Window 'Peer id' improvements~~ Peers Window rename 'Peer id' to Peer May 5, 2021

jarolrod changed the title ~~Peers Window rename 'Peer id' to Peer~~ Peers Window rename 'Peer id' to 'Peer' May 5, 2021

hebasto added the UI All about "look and feel" label May 9, 2021

hebasto added the Translations label May 25, 2021

hebasto approved these changes May 25, 2021

View reviewed changes

qt: add translator comments for peers table columns

657b33e

Adds Qt Translator Comments to each Peers Table column to aid translators by providing context.

jarolrod force-pushed the peer_id_improv branch from b405f19 to 657b33e Compare May 26, 2021 01:11

jarolrod mentioned this pull request May 26, 2021

Add Direction column to Peers Tab #317

Merged

jarolrod mentioned this pull request May 26, 2021

Peers window Peer id improvements #290

Closed

hebasto approved these changes May 26, 2021

View reviewed changes

hebasto merged commit 5c041cb into bitcoin-core:master May 26, 2021

jarolrod mentioned this pull request May 26, 2021

Add Copy address Peers Tab Context Menu Action #318

Merged

hebasto mentioned this pull request May 27, 2021

WIP: translate strings (#288) #292

Closed

hebasto mentioned this pull request May 27, 2021

Handle peer addition/removal in a right way #164

Merged

gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022

Merge 5c041cb into merged_master (Bitcoin PR bitcoin-core/gui#311)

6d8ad49

bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Peers Window rename 'Peer id' to 'Peer' #311

Peers Window rename 'Peer id' to 'Peer' #311

jarolrod commented May 3, 2021 •

edited

Loading

hebasto commented May 3, 2021

jarolrod commented May 4, 2021

jarolrod commented May 5, 2021

hebasto commented May 9, 2021 •

edited

Loading

jonatack commented May 10, 2021

jonatack commented May 10, 2021 •

edited

Loading

hebasto commented May 10, 2021

RandyMcMillan commented May 11, 2021

jonatack commented May 11, 2021 •

edited

Loading

hebasto commented May 12, 2021

jonatack commented May 12, 2021

hebasto commented May 12, 2021

promag commented May 12, 2021

RandyMcMillan commented May 12, 2021

jarolrod commented May 22, 2021

hebasto left a comment

hebasto May 25, 2021

jarolrod May 25, 2021

hebasto May 25, 2021

jonatack May 25, 2021

hebasto May 25, 2021

jonatack May 25, 2021

hebasto May 25, 2021

jonatack May 25, 2021

hebasto May 25, 2021

hebasto May 25, 2021

jarolrod commented May 26, 2021 •

edited

Loading

jonatack commented May 26, 2021

hebasto left a comment

		/*: Title of Peers Table column which contains a value for
		the type of connection we have established with the peer.

		/*: Title of Peers Table column which contains a value for
		the network the peer resides on. */

Peers Window rename 'Peer id' to 'Peer' #311

Peers Window rename 'Peer id' to 'Peer' #311

Conversation

jarolrod commented May 3, 2021 • edited Loading

hebasto commented May 3, 2021

jarolrod commented May 4, 2021

jarolrod commented May 5, 2021

hebasto commented May 9, 2021 • edited Loading

jonatack commented May 10, 2021

jonatack commented May 10, 2021 • edited Loading

hebasto commented May 10, 2021

RandyMcMillan commented May 11, 2021

jonatack commented May 11, 2021 • edited Loading

hebasto commented May 12, 2021

jonatack commented May 12, 2021

hebasto commented May 12, 2021

promag commented May 12, 2021

RandyMcMillan commented May 12, 2021

jarolrod commented May 22, 2021

hebasto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jarolrod commented May 26, 2021 • edited Loading

jonatack commented May 26, 2021

hebasto left a comment

Choose a reason for hiding this comment

jarolrod commented May 3, 2021 •

edited

Loading

hebasto commented May 9, 2021 •

edited

Loading

jonatack commented May 10, 2021 •

edited

Loading

jonatack commented May 11, 2021 •

edited

Loading

jarolrod commented May 26, 2021 •

edited

Loading