Add and improve translator comments and tooltips for peers tab address fields #554
Conversation
jonatack
force-pushed
the
improve-peers-tab-address-fields-extracomments-and-tooltips
branch
from
e25e88a
to
bcd72ef
Compare
|
Updated per @promag feedback (thanks!) |
There was a problem hiding this comment.
ACK bcd72ef
I've been collecting thoughts on how to formulate translator comments here and the translator comments introduced here tick the boxes.
in reference to the translator comment documentation I've prepared: in 1df9daa you allude to what the value of the field is, I wonder if I should include that point as required context in the doc.
If you retouch, and definitely not necessary, you could rename the PR to Add and improve peers tab address translator comments and tooltips and similarly update the commits to state they are updating translator comments instead of extracomment.
jonatack
changed the title
jonatack
changed the title
jonatack
force-pushed
the
improve-peers-tab-address-fields-extracomments-and-tooltips
branch
from
bcd72ef
to
4d2b503
Compare
Describing the value(s) of the field where relevant and helpful seems like a good idea. (Nice doc BTW.)
Done! |
jonatack
deleted the
improve-peers-tab-address-fields-extracomments-and-tooltips
branch
…ooltips for peers tab address fields 4d2b503 gui: improve "Addresses Rate-Limited" translator comments and tooltip in peers tab (Jon Atack) 81ef1f7 gui: improve "Addresses Processed" translator comments and tooltip in peers tab (Jon Atack) 77f24aa gui: improve "Address Relay" translator comments and tooltip in peers tab (Jon Atack) Pull request description: Per translator feedback in this thread: bitcoin-core/gui#526 (comment) *"The lack of string context in Transifex is a real problem for this project, as proper context (dev notes and/or screenshots) are essential to achieve quality translations."* This pull adds developer notes for transifex translators via `extracomment` tags, and it improves the existing ones and their tooltips with more context, clarity and completeness for the following peer tab fields as a follow-up to bitcoin-core/gui#526: - address relay - addresses processed - addressed rate-limited It looks like only six lines of diff, but they are loooong lines. If this is the right direction, the same can be done for other fields in follow-ups. ACKs for top commit: jarolrod: re-ACK [4d2b503](bitcoin-core/gui@4d2b503) hebasto: ACK 4d2b503, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: a185f46a66375a5fd6854640745b7d1d00740cf7be58db03256f44d71acc351e1770de137cb3bc9c1f0ea3cabd7cfa1cb1ccb87ec0df222680924ca3dab6c8bf
Per translator feedback in this thread: #526 (comment)
"The lack of string context in Transifex is a real problem for this project, as proper context (dev notes and/or screenshots) are essential to achieve quality translations."
This pull adds developer notes for transifex translators via
extracommenttags, and it improves the existing ones and their tooltips with more context, clarity and completeness for the following peer tab fields as a follow-up to #526:It looks like only six lines of diff, but they are loooong lines.
If this is the right direction, the same can be done for other fields in follow-ups.