Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: Log static plugins meta data and used style #72

Merged
merged 1 commit into from
Jan 28, 2021
Merged

util: Log static plugins meta data and used style #72

merged 1 commit into from
Jan 28, 2021

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Aug 24, 2020 •
edited
Loading

This PR is a follow-up of bitcoin/bitcoin#17826, and adds additional info about the imported static plugins and the used style to the debug.log I found useful for testing (e.g., with QT_QPA_PLATFORM, QT_QPA_PLATFORMTHEME, QT_STYLE_OVERRIDE variables) and debugging issues (e.g., bitcoin/bitcoin#19716 (comment)).

The excerpt from the log:

2020-11-15T18:41:45Z [main] Bitcoin Core version v0.20.99.0-f0b933f78 (release build)
2020-11-15T18:41:45Z [main] Qt 5.9.8 (static), plugin=xcb (static)
2020-11-15T18:41:45Z [main] Static plugins:
2020-11-15T18:41:45Z [main]  QXcbIntegrationPlugin, version 329992
2020-11-15T18:41:45Z [main] Style: fusion / QFusionStyle
...

@hebasto
Copy link
Member Author

hebasto commented Aug 24, 2020

cc @fanquake

@fanquake
Copy link
Member

Concept ACK

1 similar comment
@maflcko
Copy link
Contributor

maflcko commented Aug 25, 2020

Concept ACK

promag
promag reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 528360a.

Tested but with brew qt 5.15.1, so no static plugins are listed.

src/qt/guiutil.cpp Outdated Show resolved Hide resolved
@hebasto
Copy link
Member Author

hebasto commented Sep 27, 2020

Updated 528360a -> b5397ad (pr72.01 -> pr72.02, diff):

promag
promag reviewed Oct 1, 2020
View reviewed changes
Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK b5397ad.

src/qt/guiutil.cpp Outdated Show resolved Hide resolved
@hebasto
Copy link
Member Author

hebasto commented Oct 1, 2020

Updated b5397ad -> 052f3eb (pr72.02 -> pr72.03, diff):

nit, could write "Static plugins:" just once before the loop.

@hebasto hebasto closed this Oct 25, 2020
@hebasto hebasto reopened this Oct 25, 2020
@hebasto
Copy link
Member Author

hebasto commented Oct 25, 2020

Rebased 052f3eb -> c45ecd3 (pr72.03 -> pr72.04).

laanwj
laanwj reviewed Nov 12, 2020
View reviewed changes
src/qt/guiutil.cpp Outdated Show resolved Hide resolved
@laanwj
Copy link
Member

laanwj commented Nov 12, 2020

Concept ACK but I don't really see the point of JSON here.

@hebasto hebasto changed the title util: Log static plugins util: Log static plugins meta data Nov 15, 2020
@hebasto hebasto changed the title util: Log static plugins meta data util: Log static plugins meta data and used style Nov 15, 2020
@hebasto
Copy link
Member Author

hebasto commented Nov 15, 2020 •
edited
Loading

Updated c45ecd3 -> f0b933f (pr72.04 -> pr72.05):

  • removed JSON from the log
  • rebased on top of the recent CI changes

@hebasto
Copy link
Member Author

hebasto commented Dec 23, 2020

Rebased 5fffd6a -> 957895c (pr72.06 -> pr72.07) on top of the recent CI changes.

jarolrod
jarolrod reviewed Jan 19, 2021
View reviewed changes
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 957895c, Tested on macOS 11.1

Since the OP Screenshot shows the case with static plugins, I tested the case without static plugins (only dynamic)

Screen Shot 2021-01-18 at 9 11 25 PM

jonasschnelli
jonasschnelli approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 957895c

@jonasschnelli jonasschnelli merged commit 7595183 into bitcoin-core:master Jan 28, 2021
@hebasto hebasto deleted the 200812-log branch January 28, 2021 09:49
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 28, 2021
@jonasschnelli
Merge bitcoin-core/gui#72: util: Log static plugins meta data and use…
7310454 
…d style

957895c util: Log static plugins meta data and style (Hennadii Stepanov)

Pull request description:

  This PR is a follow-up of bitcoin#17826, and adds additional info about the imported static plugins and the used style to the `debug.log` I found useful for testing (e.g., with `QT_QPA_PLATFORM`, `QT_QPA_PLATFORMTHEME`, `QT_STYLE_OVERRIDE` variables) and debugging issues (e.g., bitcoin#19716 (comment)).

  The excerpt from the log:
  ```
  2020-11-15T18:41:45Z [main] Bitcoin Core version v0.20.99.0-f0b933f78 (release build)
  2020-11-15T18:41:45Z [main] Qt 5.9.8 (static), plugin=xcb (static)
  2020-11-15T18:41:45Z [main] Static plugins:
  2020-11-15T18:41:45Z [main]  QXcbIntegrationPlugin, version 329992
  2020-11-15T18:41:45Z [main] Style: fusion / QFusionStyle
  ...
  ```

ACKs for top commit:
  jarolrod:
    ACK 957895c, Tested on macOS 11.1
  jonasschnelli:
    utACK 957895c

Tree-SHA512: 0e46db7560f380fbda8ce5e53faa5d419a456e90ca595ce46be8e3030c99d3a113586edad1988a97e9bf0279e944f975968ed1156817bc16723ed31c64850239
@laanwj
Copy link
Member

laanwj commented Jan 28, 2021

Posthumous ACK

DeckerSU added a commit to DeckerSU/KomodoOcean that referenced this pull request Nov 15, 2021
@DeckerSU
add LogQtInfo to log short info about the used Qt and the host system
f5e45e9 
- bitcoin/bitcoin@957895c
- bitcoin-core/gui#72
- bitcoin-core/gui@07efb3f
TheComputerGenie pushed a commit to TheComputerGenie/KomodoOcean that referenced this pull request Jan 5, 2022
@DeckerSU
add LogQtInfo to log short info about the used Qt and the host system
4cce803 
- bitcoin/bitcoin@957895c
- bitcoin-core/gui#72
- bitcoin-core/gui@07efb3f
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laanwj laanwj laanwj left review comments

@promag promag promag left review comments

@jarolrod jarolrod jarolrod left review comments

@jonasschnelli jonasschnelli jonasschnelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hebasto @fanquake @maflcko @laanwj @jonasschnelli @promag @jarolrod