build: Qt 5.15.x #19716

fanquake · 2020-08-14T07:44:05Z

Opening this for visibility. Apart from it probably being time to use a newer version of Qt for releases, an update is required so that we are using a version which has a C++17 mode.

There's a lot of commits here, because I've made some changes (like rebasing our patches), that aren't strictly necessary. There are also some changes, like bumping the minimum required macOS version, that will likely happen separate, as part of the C++17 migration. So this change will end up being a bit smaller.

The biggest change here is that Qt no longer has internal xcb libs, so we need to build the requirements ourselves. This also means some additional build-time tools, such as yacc (from bison) are also required; to build xkbcommon.

I've tested this on Ubuntu; although it'd be great if more people could test with their particular brand of Linux desktop.

Cross-compiled Windows and macOS builds compile and run, but the GUI currently looks a bit broken on both. i.e macOS seems to look a bit like an older version of Windows:

I haven't had enough time to fully investigate (also why there's some WIP commits), so if anyone wants to dig in and see what Qt has changed since 5.9.x feel free.

maflcko · 2020-08-14T07:52:20Z

Added 0.22 milestone based on the assumption that none of this is required to build with a qt5.15 system package? (Only depends changes here?)

fanquake · 2020-08-14T07:59:30Z

the assumption that none of this is required to build with a qt5.15 system package?

As far as I'm aware people have already been building with Qt 5.15, and that has been working after #19097.

jonasschnelli · 2020-08-14T08:23:07Z

Thanks!
It's currently failing on gitian: https://bitcoin.jonasschnelli.ch/gitian/builds/231/build_osx.log

hebasto · 2020-08-14T12:35:28Z

@fanquake

Cross-compiled Windows and macOS builds compile and run, but the GUI currently looks a bit broken on both. i.e macOS seems to look a bit like an older version of Windows:

I found this hebasto@528360a useful for diagnostics such issues. Feel free to integrate :)

promag · 2020-08-16T23:18:59Z

Nice work! I already used Qt 5.15 on macos and I don't think it looked like that. Will check this soon™

vasild · 2020-08-19T12:43:16Z

There are a bunch of compilation warnings on master and on this PR with Qt 5.15.0 like:

src/qt/transactionview.cpp:587:13: warning: 'QDateTime' is deprecated: Use QDate::startOfDay() [-Wdeprecated-declarations]
            QDateTime(dateTo->date()).addDays(1));
            ^

Here is a fix:

Fix -Wdeprecated-declarations warnings with Qt 5.15

diff --git i/src/qt/sendcoinsdialog.cpp w/src/qt/sendcoinsdialog.cpp
index 97fb88d71..786af1a73 100644
--- i/src/qt/sendcoinsdialog.cpp
+++ w/src/qt/sendcoinsdialog.cpp
@@ -168,14 +168,14 @@ void SendCoinsDialog::setModel(WalletModel *_model)
         // fee section
         for (const int n : confTargets) {
             ui->confTargetSelector->addItem(tr("%1 (%2 blocks)").arg(GUIUtil::formatNiceTimeOffset(n*Params().GetConsensus().nPowTargetSpacing)).arg(n));
         }
         connect(ui->confTargetSelector, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, &SendCoinsDialog::updateSmartFeeLabel);
         connect(ui->confTargetSelector, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, &SendCoinsDialog::coinControlUpdateLabels);
-        connect(ui->groupFee, static_cast<void (QButtonGroup::*)(int)>(&QButtonGroup::buttonClicked), this, &SendCoinsDialog::updateFeeSectionControls);
-        connect(ui->groupFee, static_cast<void (QButtonGroup::*)(int)>(&QButtonGroup::buttonClicked), this, &SendCoinsDialog::coinControlUpdateLabels);
+        connect(ui->groupFee, &QButtonGroup::idClicked, this, &SendCoinsDialog::updateFeeSectionControls);
+        connect(ui->groupFee, &QButtonGroup::idClicked, this, &SendCoinsDialog::coinControlUpdateLabels);
         connect(ui->customFee, &BitcoinAmountField::valueChanged, this, &SendCoinsDialog::coinControlUpdateLabels);
         connect(ui->optInRBF, &QCheckBox::stateChanged, this, &SendCoinsDialog::updateSmartFeeLabel);
         connect(ui->optInRBF, &QCheckBox::stateChanged, this, &SendCoinsDialog::coinControlUpdateLabels);
         CAmount requiredFee = model->wallet().getRequiredFee(1000);
         ui->customFee->SetMinValue(requiredFee);
         if (ui->customFee->value() < requiredFee) {
diff --git i/src/qt/transactionview.cpp w/src/qt/transactionview.cpp
index 54ecfc38e..5f638f559 100644
--- i/src/qt/transactionview.cpp
+++ w/src/qt/transactionview.cpp
@@ -234,13 +234,13 @@ void TransactionView::setModel(WalletModel *_model)
 
         columnResizingFixer = new GUIUtil::TableViewLastColumnResizingFixer(transactionView, AMOUNT_MINIMUM_COLUMN_WIDTH, MINIMUM_COLUMN_WIDTH, this);
 
         if (_model->getOptionsModel())
         {
             // Add third party transaction URLs to context menu
-            QStringList listUrls = _model->getOptionsModel()->getThirdPartyTxUrls().split("|", QString::SkipEmptyParts);
+            QStringList listUrls = _model->getOptionsModel()->getThirdPartyTxUrls().split("|", Qt::SkipEmptyParts);
             for (int i = 0; i < listUrls.size(); ++i)
             {
                 QString url = listUrls[i].trimmed();
                 QString host = QUrl(url, QUrl::StrictMode).host();
                 if (!host.isEmpty())
                 {
@@ -272,36 +272,36 @@ void TransactionView::chooseDate(int idx)
         transactionProxyModel->setDateRange(
                 TransactionFilterProxy::MIN_DATE,
                 TransactionFilterProxy::MAX_DATE);
         break;
     case Today:
         transactionProxyModel->setDateRange(
-                QDateTime(current),
+                current.startOfDay(),
                 TransactionFilterProxy::MAX_DATE);
         break;
     case ThisWeek: {
         // Find last Monday
         QDate startOfWeek = current.addDays(-(current.dayOfWeek()-1));
         transactionProxyModel->setDateRange(
-                QDateTime(startOfWeek),
+                startOfWeek.startOfDay(),
                 TransactionFilterProxy::MAX_DATE);
 
         } break;
     case ThisMonth:
         transactionProxyModel->setDateRange(
-                QDateTime(QDate(current.year(), current.month(), 1)),
+                QDate(current.year(), current.month(), 1).startOfDay(),
                 TransactionFilterProxy::MAX_DATE);
         break;
     case LastMonth:
         transactionProxyModel->setDateRange(
-                QDateTime(QDate(current.year(), current.month(), 1).addMonths(-1)),
-                QDateTime(QDate(current.year(), current.month(), 1)));
+                QDate(current.year(), current.month(), 1).addMonths(-1).startOfDay(),
+                QDate(current.year(), current.month(), 1).startOfDay());
         break;
     case ThisYear:
         transactionProxyModel->setDateRange(
-                QDateTime(QDate(current.year(), 1, 1)),
+                QDate(current.year(), 1, 1).startOfDay(),
                 TransactionFilterProxy::MAX_DATE);
         break;
     case Range:
         dateRangeWidget->setVisible(true);
         dateRangeChanged();
         break;
@@ -580,14 +580,14 @@ QWidget *TransactionView::createDateRangeWidget()
 
 void TransactionView::dateRangeChanged()
 {
     if(!transactionProxyModel)
         return;
     transactionProxyModel->setDateRange(
-            QDateTime(dateFrom->date()),
-            QDateTime(dateTo->date()).addDays(1));
+            dateFrom->date().startOfDay(),
+            dateTo->date().startOfDay().addDays(1));
 }
 
 void TransactionView::focusTransaction(const QModelIndex &idx)
 {
     if(!transactionProxyModel)
         return;

qt_5.15_fix_deprecation_warnings.diff.txt

fanquake · 2020-08-19T12:45:28Z

@vasild Thanks. See bitcoin-core/gui#46 which should take care of all of them.

DrahtBot · 2020-08-20T20:32:58Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

depends: Use Qt top-level build facilities #20641 (depends: Use Qt top-level build facilities by hebasto)
build: Fix Qt processing of configure script for depends with DEBUG=1 #18298 (build: Fix Qt processing of configure script for depends with DEBUG=1 by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

fanquake · 2020-08-24T12:15:04Z

I've fixed up a bunch of things here.
Rebased for #19689.
Dropped the [WIP] qt commits and merged the relevant changes in to the qt 5.15.x commit.
Modified the libxcb_util_image fix to be a patch file rather than using sed.
Added a commit that should be enough to get the CI running.
Fixed the docs for the dependency changes.

Note that Qt 5.15.1 has been tagged (no downloads yet), so once that's up I'll swap over.

Also dumped some output using @hebasto's patch. Turns out the macOS UI looks like Windows because the Windows style is being used.. Unclear why this is happening. Will investigate. Debug output:

2020-08-24T11:22:47.398810Z [main] Bitcoin Core version v0.20.99.0-1971aead8-dirty (release build)
2020-08-24T11:22:47.398842Z [main] Qt 5.15.0 (static), plugin=cocoa (static)
2020-08-24T11:22:47.398936Z [main] Static Plugin: {"IID":"org.qt-project.Qt.QPA.QPlatformIntegrationFactoryInterface.5.3","MetaData":{"Keys":["cocoa"]},"archreq":0,"className":"QCocoaIntegrationPlugin","debug":false,"version":331520}
2020-08-24T11:22:47.398959Z [main] Style=windows / QWindowsStyle
2020-08-24T11:22:47.398973Z [main] System: macOS 10.15, x86_64-little_endian-lp64
2020-08-24T11:22:47.398987Z [main] Screen: Color LCD 1680x1050, pixel ratio=2.0
2020-08-24T11:22:47.398997Z [main] Screen: LG HDR 4K 2560x1440, pixel ratio=2.0
2020-08-24T11:22:47.958407Z [main] GUI: Populating font family aliases took 512 ms. Replace uses of missing font family ".AppleSystemUIFont,13,-1,5,50,0,0,0,0,0" with one that exists to avoid this cost. 
2020-08-24T11:22:48.816413Z [main] GUI: initializeResult : Initialization result:  true
2020-08-24T11:22:48.821713Z [main] GUI: Platform customization: "macosx"

ci/test/00_setup_env.sh

hebasto · 2020-08-25T08:59:27Z

It seems the CentOS build is a subject of https://bugreports.qt.io/browse/QTBUG-85669

depends/packages/qt.mk

maflcko · 2020-08-25T09:29:14Z

This is currently assigned to the 0.22 milestone, by which time both centos:7 and xenial are no longer supported. So no need to test on them right now.

hebasto · 2020-08-25T09:36:57Z

This is currently assigned to the 0.22 milestone, by which time both centos:7 and xenial are no longer supported. So no need to test on them right now.

So let's remove them from CI jobs in this PR.

hebasto · 2020-08-25T10:09:43Z

macOS 10.12 build error (on Travis):

Project ERROR: Cannot run target compiler 'x86_64-apple-darwin16-clang++'. Output:
===================
===================
Maybe you forgot to setup the environment?

hebasto · 2020-08-25T10:40:13Z

Windows build on Travis is a subject of https://forum.qt.io/topic/113250/building-qt-fails-with-missing-dxgil_3-h

hebasto · 2020-08-25T10:49:01Z

It would be nice to add a doc commit with the minimum MinGW version requirement:

https://doc.qt.io/qt-5/windows-requirements.html#gcc-mingw-builds

hebasto · 2020-08-25T11:20:09Z

Windows build on Travis is a subject of https://forum.qt.io/topic/113250/building-qt-fails-with-missing-dxgil_3-h

Could be fixed by bumping Ubuntu version up to 20.04:

--- a/ci/test/00_setup_env_win64.sh
+++ b/ci/test/00_setup_env_win64.sh
@@ -7,7 +7,7 @@
 export LC_ALL=C.UTF-8
 
 export CONTAINER_NAME=ci_win64
-export DOCKER_NAME_TAG=ubuntu:18.04  # Check that bionic can cross-compile to win64 (bionic is used in the gitian build as well)
+export DOCKER_NAME_TAG=ubuntu:20.04
 export HOST=x86_64-w64-mingw32
 export PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine-binfmt wine64"
 export RUN_FUNCTIONAL_TESTS=false

DrahtBot · 2021-02-12T21:43:34Z

Gitian builds

File	commit `b69eab9` (master)	commit `a85341f` (master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`c5fa5486923407ad...`	`237b175a3d490908...`
*-aarch64-linux-gnu.tar.gz	`70fb6e1a9d4ba982...`	`df4e10be78d1818a...`
*-arm-linux-gnueabihf-debug.tar.gz	`8a9ff7cbb07d3610...`	`f59262ebcd41f36b...`
*-arm-linux-gnueabihf.tar.gz	`ec50c9918479cf6e...`	`c68bd696e2f0b050...`
*-osx-unsigned.dmg	`91af0e1832b97596...`	`1a5ccc8d441d98a8...`
*-osx64.tar.gz	`c8442bc118faf6b9...`	`5a7461590034f51b...`
*-powerpc64-linux-gnu-debug.tar.gz	`c0ab553964e4b990...`	`88481a1519e85c1e...`
*-powerpc64-linux-gnu.tar.gz	`04df9adf29c38cc1...`	`69baba10885ff4db...`
*-powerpc64le-linux-gnu-debug.tar.gz	`36fc8fc54968e48d...`	`327e2cb66d9c9f32...`
*-powerpc64le-linux-gnu.tar.gz	`fe832434b2b216f9...`	`2d341bed8323371d...`
*-riscv64-linux-gnu-debug.tar.gz	`154bc3714a3e9a62...`	`a1bb4c40011470f8...`
*-riscv64-linux-gnu.tar.gz	`e94bdad7e34c344c...`	`f435b0d94bce2669...`
*-win64-debug.zip	`7c302a10100fef9e...`
*-win64-setup-unsigned.exe	`7721a0e923f9a6a8...`
*-win64.zip	`9e86debd85c34b51...`
*-x86_64-linux-gnu-debug.tar.gz	`055a65b474d29d93...`	`332070633bc5ab80...`
*-x86_64-linux-gnu.tar.gz	`61c01306b0f3d965...`	`b6da26666d0e713c...`
*.tar.gz	`95d10633aa05a3f1...`	`895c79f389973f68...`
bitcoin-core-linux-22-res.yml	`c6e22aacac425c60...`	`16d159a458e1758c...`
bitcoin-core-osx-22-res.yml	`0895d3848e391422...`	`396500ef35da3f71...`
bitcoin-core-win-22-res.yml	`9529c497b7d2a1ba...`
linux-build.log	`f815452191141dcd...`	`23657c74f8bc680a...`
osx-build.log	`18ff763035a0d62e...`	`bec8b364d365ae66...`
win-build.log	`542fa9b97e1cd10c...`	`da2eab4c7aecafcb...`
bitcoin-core-linux-22-res.yml.diff		`14d09a2fc0f18105...`
bitcoin-core-osx-22-res.yml.diff		`51f08b318e5c7068...`
linux-build.log.diff		`d02392065ba1ed4b...`
osx-build.log.diff		`3ee7cc51b8e4f011...`
win-build.log.diff		`e2fcec2f7ecda2a1...`

maflcko · 2021-02-13T07:40:55Z

make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32'
+ make -j1 -C src check-security
make: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
Checking binary security...
make: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
+ make -j1 -C src check-symbols
make: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
Checking Windows dynamic libraries...
NETAPI32.dll is not in ALLOWED_LIBRARIES!
ole32.dll is not in ALLOWED_LIBRARIES!
qt/bitcoin-qt.exe: failed DYNAMIC_LIBRARIES
make: *** [Makefile:16867: check-symbols] Error 1
make: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'

67f2631 gui: Add monospaced font settings (Hennadii Stepanov) 22e0114 qt: Choose monospaced font in C++ code rather in `*.ui` file (Hennadii Stepanov) 623de12 qt: Make GUIUtil::fixedPitchFont aware of embedded font (Hennadii Stepanov) 89e4219 gui: Add Roboto Mono font (Hennadii Stepanov) Pull request description: Qt does not guarantee that the actual applied font matches to the requested one. It was noted (bitcoin/bitcoin#16432 (comment)): > the monospace font looks a bit weird no macOS ... because it is _not_ monospaced. Also some discrepancies I've noted on Windows while testing Qt 5.15 ([#19716](bitcoin/bitcoin#19716)). Of course, we could check the actual font with `QFontInfo`, and try to choose another font. But this PR suggests to just embed a monospaced font, and get the GUI look (partially) independent from a platform. [Roboto Mono](https://fonts.google.com/specimen/Roboto+Mono) was chosen after discussion with Bitcoin Design community, and due to its [Apache License, Version 2.0](https://fonts.google.com/specimen/Roboto+Mono#license). Changes are scoped to the Overview page only. --- Screenshots on macOS 10.15.6 (images are simulated by code patching): - master (ca30d34) ![Screenshot from 2020-09-03 14-10-03](https://user-images.githubusercontent.com/32963518/92107902-30357d80-edef-11ea-8a4f-b4c758eebf66.png) - this PR (3fdd5b6) ![Screenshot from 2020-09-03 15-41-36](https://user-images.githubusercontent.com/32963518/92116277-4b5aba00-edfc-11ea-8cb9-22fc44460bfb.png) --- More screenshots added after #79 (comment): - Linux Mint 20.1 + Cinnamon DE ![DeepinScreenshot_select-area_20210221205410](https://user-images.githubusercontent.com/32963518/108635739-b327be80-7489-11eb-8851-ac89f61199ee.png) - Windows 10 (with depends) ![DeepinScreenshot_select-area_20210221205056](https://user-images.githubusercontent.com/32963518/108635741-b6bb4580-7489-11eb-8b6b-66be5551eb8c.png) - macOS Big Sur (with depends) ![DeepinScreenshot_select-area_20210221202917](https://user-images.githubusercontent.com/32963518/108635746-bd49bd00-7489-11eb-8cd2-cf4bb2273a6d.png) ACKs for top commit: laanwj: Tested ACK 67f2631 Tree-SHA512: a59775570b8ce314669ede50a0b69f53e8a47a41e7eea428835013240f0ce9afcff6e4c258895455b56806417ed877e5b7a9522f1904e95a5f435db8ccf6078c

DrahtBot · 2021-03-03T08:52:11Z

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

fanquake · 2021-03-03T09:39:21Z

Going to propose some smaller, simpler changes. New PR as they are substantially different from what is here.

550ed1b build: update qt qpaint non determinism patch for 5.12.10 (fanquake) 6093ae4 build: update qt no-xlib patch for 5.12.10 (fanquake) 84928c4 build: update qt android jni static patch for 5.12.10 (fanquake) cc6f47d build: update qt lrelease patch for 5.12.10 (fanquake) 286d07f build, qt: Fix lib paths in *.pc files (Hennadii Stepanov) fa5e97e build: disable qt SDK version checking (fanquake) 1be8e0f build: Add QMacStyle support (Hennadii Stepanov) e674e94 build: revert to using Qts internal zlib (fanquake) 06cd0da build: qt 5.12.10 (fanquake) 3272e34 build: Add xkbcommon 0.8.4 (Hennadii Stepanov) d769b33 build: only pass -optimized-tools to qt in debug mode (fanquake) Pull request description: Switch to Qt 5.12.10 in depends. Based on #21363. This is a much smaller changeset, and should be easier to review than #19716. Also postpones needing to bring a bunch of new libs into depends. Big thanks to Hebasto that has been helping with this. ACKs for top commit: laanwj: Code review ACK 550ed1b hebasto: ACK 550ed1b jarolrod: ACK 550ed1b , tested on macOS 11.2 built from depends Tree-SHA512: cb6b70f5a5372ba0b64f7ddfa696eda0411922cd261c67bfa2d9332c685a7b358ab18e5cfaa677b414ae8ad78296bba6ed0eecd071fdacdf736a0d030f679fe5

…uild system 267f259 depends: Drop workaround for a fixed bug in Qt build system (Hennadii Stepanov) Pull request description: This PR drops workaround that was [introduced](bitcoin@1dec09b) for Qt 5.2.1 for a bug in Qt build system that has been fixed in Qt 5.3.0. The bug reports: - https://bugreports.qt.io/browse/QTBUG-35444 - https://bugreports.qt.io/browse/QTBUG-32519 I've noted this change is a part of the bitcoin#19716, but I think that a separate commit with the documented reason will benefit it. ACKs for top commit: laanwj: Code review ACK 267f259 jonasschnelli: code Review ACK 267f259 practicalswift: cr ACK 267f259: patch looks correct Tree-SHA512: b994f94776b4f8bb2f996095c87c7fef55e74d1e64852a890d664275e3739ec890ee388b10baa15445dd24ec7b971ce57d396cb062dbed933c18b6b69525349f

2ecaf21 gitian: remove execstack workaround for ricv64 & powerpc64le (fanquake) 5baff2b build: use focal in gitian descriptors (fanquake) Pull request description: This PR changes the gitian descriptors to use Ubuntu Focal (20.04), over Bionic (18.04), moving from GCC 7.5 to GCC 8.4 for native Linux builds, mingw-w64 GCC 7.3 to mingw-w64 GCC 9.3 for Windows builds, while continuing to use GCC 8.4 for all cross builds and Clang 8.0.0 for macOS builds. It also drops the `-Wl,-z,noexecstack` workaround we've been using for the riscv64 and powerpc64le hosts, as it's no-longer needed. One new package is installed in the osx build, `libtinfo5`, as libtinfo5.so is required by our downloaded Clang 8. A bump to Focal will at least be required if we want to update to a newer Qt (5.15, bitcoin#19716) for 22.0, as we need a newer version of [`g++-mingw-w64`](https://packages.ubuntu.com/focal/g++-mingw-w64-x86-64) and the [`mingw-w64`](https://mingw-w64.org/doku.php) headers. This can still be done while continuing to use GCC 8.4 for Linux builds (see below), however the newer `g++-mingw-w64` will be based off of GCC 9.3. **Some considerations** GCC 9 is affected by bitcoin#20005 "memcmp with constants that contain zero bytes are broken in GCC", and the newer `g++-mingw-w64` will be based off of GCC 9.3. The `--no-*` variants of the Windows linker flags (i.e `--no-dynamicbase`) we use to [test our `security-check.py` script](https://github.com/bitcoin/bitcoin/blob/16b784d953365bb2d7ae65acd2b20a79ef8ba7b6/contrib/devtools/test-security-check.py#L53) are not patched into the mingw binutils in Focal (they have been re-added in Groovy (20.10)). This isn't currently an issue, however, we might add a call to `test-security-check` for Guix (bitcoin#20980), and if we wanted to do the same for gitian, it would not work. Note how it's quite "easy" for us to apply the `--no-*` variant patch to our Guix build; it would be quite a bit harder to do in Gitian. Gitian Builds @ 2ecaf21 #### Linux ```bash 8882ea78486fbae4fac574b9089eb1107c6372d0dd7dfcda4f0f930576f9d6c1 bitcoin-2ecaf214331b-aarch64-linux-gnu-debug.tar.gz 50a9e30943b4eee5163edff3331241e745ff32a2c4463c21a6fdc5986e2d0383 bitcoin-2ecaf214331b-aarch64-linux-gnu.tar.gz ec4e55a447fddf033fee33cd5f22bfeda3c3612f059194bcf6238859f7989d7a bitcoin-2ecaf214331b-arm-linux-gnueabihf-debug.tar.gz 444fe1b3b933c00bcbd4a9d86888cff3b61c1215b1debccd2843e842d1224777 bitcoin-2ecaf214331b-arm-linux-gnueabihf.tar.gz 88e486ff465980dc1a4aab9687d142ec6f727ed2c52cf539f69db2877dee83b2 bitcoin-2ecaf214331b-powerpc64-linux-gnu-debug.tar.gz 66144ac264c65cada9d86446e6026c85b04fb88198b8f41b42840f6031db3e6c bitcoin-2ecaf214331b-powerpc64-linux-gnu.tar.gz 34bcc13d78d929d575e34e77a6672f23ca7ea23230b28ec2eed563889352ba86 bitcoin-2ecaf214331b-powerpc64le-linux-gnu-debug.tar.gz b4c5f959664f3063df4330edfe343c17120eb6b556ee1c15c4aeb2c1c54ffd49 bitcoin-2ecaf214331b-powerpc64le-linux-gnu.tar.gz 918fa72ab6f6ebce4e9663c93f72fe26651c260477cbb54749f7eb61438b5cc1 bitcoin-2ecaf214331b-riscv64-linux-gnu-debug.tar.gz f704f9f8c053ffe37d854e2e81e0f4c0614c435dad7f5d82518c681b73a76ae6 bitcoin-2ecaf214331b-riscv64-linux-gnu.tar.gz b59e3a62f1df9d79f30e916b3c9655f654036fe3a420040c53acc8dd9f4162c5 bitcoin-2ecaf214331b-x86_64-linux-gnu-debug.tar.gz a4dc9ca877cc97544e65db11be38406d16f15d74fcdcd2318bb92474729bc60d bitcoin-2ecaf214331b-x86_64-linux-gnu.tar.gz b40ba2d5da498330ade92a4ccebcceb1452b94c8ffeacb336f87e93b5c88d8af src/bitcoin-2ecaf214331b.tar.gz af6ebc91147778e4e6705eade62608dde4d6e60522d79087fa9129bdb7c01199 bitcoin-core-linux-22-res.yml ``` #### Windows ```bash 121a3970a6911cb8c453b2ce37d03f6cbb43333e29db8fa516c68563fb367f43 bitcoin-2ecaf214331b-win-unsigned.tar.gz 6294e9efebe935092f9ba119dc60ad4094f18b51c4181324e54d3057524d6101 bitcoin-2ecaf214331b-win64-debug.zip 5b5a236b63e67f5f6c07ad9aa716aa7b72fb63722c96798b332c6d164738f9cf bitcoin-2ecaf214331b-win64-setup-unsigned.exe c1fa5894c5e02a201637567c80b9bde9024f44673dcd06fd4d489c1709179279 bitcoin-2ecaf214331b-win64.zip b40ba2d5da498330ade92a4ccebcceb1452b94c8ffeacb336f87e93b5c88d8af src/bitcoin-2ecaf214331b.tar.gz 665fd7eb61aed368150db58a254f15fb5efb51a4efa5abcc52571cb7a1a5de22 bitcoin-core-win-22-res.yml ``` #### macOS ```bash 6a1deae7662aa782baa82a42590f862c6bcdc4f4e38daa9b8c2a9eed1fbb5397 bitcoin-2ecaf214331b-osx-unsigned.dmg 1ee843266e84928a4323fa255c833528c2617a2c9fd2f98fb26ba19bbfc1227b bitcoin-2ecaf214331b-osx-unsigned.tar.gz 097b64dadc167d8e5b733421bf1541a40760ad952990f7cf3f35adc6ae2616d0 bitcoin-2ecaf214331b-osx64.tar.gz b40ba2d5da498330ade92a4ccebcceb1452b94c8ffeacb336f87e93b5c88d8af src/bitcoin-2ecaf214331b.tar.gz 6e378fb543928e40c7119b96be6ff773d38506a9a888f8b02c7f1b8a0801a80e bitcoin-core-osx-22-res.yml ``` ACKs for top commit: laanwj: Build script changes review ACK 2ecaf21 Tree-SHA512: 975d5830b787d2e08988f43cbc6e839294171c1d94c8219636308b05f9b77041421612ae67be24a631674670cfc9c2d96d8177f2b3158a78fc3deea19631febf

…uild system 267f259 depends: Drop workaround for a fixed bug in Qt build system (Hennadii Stepanov) Pull request description: This PR drops workaround that was [introduced](bitcoin@1dec09b) for Qt 5.2.1 for a bug in Qt build system that has been fixed in Qt 5.3.0. The bug reports: - https://bugreports.qt.io/browse/QTBUG-35444 - https://bugreports.qt.io/browse/QTBUG-32519 I've noted this change is a part of the bitcoin#19716, but I think that a separate commit with the documented reason will benefit it. ACKs for top commit: laanwj: Code review ACK 267f259 jonasschnelli: code Review ACK 267f259 practicalswift: cr ACK 267f259: patch looks correct Tree-SHA512: b994f94776b4f8bb2f996095c87c7fef55e74d1e64852a890d664275e3739ec890ee388b10baa15445dd24ec7b971ce57d396cb062dbed933c18b6b69525349f

fanquake added GUI Build system labels Aug 14, 2020

maflcko added this to the 0.22.0 milestone Aug 14, 2020

fanquake mentioned this pull request Aug 18, 2020

build: improve sed robustness by not using sed #19761

Merged

DrahtBot mentioned this pull request Aug 20, 2020

depends: Split libpng out of Qt #19751

Closed

fanquake force-pushed the qt_5_15_x branch from e90843c to 1e17e10 Compare August 24, 2020 12:13

hebasto mentioned this pull request Aug 24, 2020

util: Log static plugins meta data and used style bitcoin-core/gui#72

Merged

DrahtBot mentioned this pull request Aug 25, 2020

Replace boost::filesystem with std::filesystem #19245

Closed

5 tasks

hebasto reviewed Aug 25, 2020

View reviewed changes

ci/test/00_setup_env.sh Outdated Show resolved Hide resolved

hebasto reviewed Aug 25, 2020

View reviewed changes

depends/packages/qt.mk Outdated Show resolved Hide resolved

DrahtBot removed the Needs gitian build label Feb 12, 2021

DrahtBot added the Needs rebase label Mar 3, 2021

fanquake closed this Mar 3, 2021

maflcko removed DrahtBot Guix build requested Needs rebase labels Mar 3, 2021

hebasto mentioned this pull request Mar 4, 2021

build, qt: Improve Qt static plugins/libs check code #21363

Merged

fanquake mentioned this pull request Mar 6, 2021

depends: Qt 5.12.10 #21376

Merged

maflcko mentioned this pull request Nov 12, 2021

build: Qt 5.15.2 #23489

Closed

This was referenced Apr 5, 2022

build: Qt 5.15.2 gridcoin-community/Gridcoin-Research#2483

Closed

build: Qt 5.15.2 gridcoin-community/Gridcoin-Research#2486

Merged

bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022

fanquake deleted the qt_5_15_x branch November 9, 2022 16:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Qt 5.15.x #19716

build: Qt 5.15.x #19716

fanquake commented Aug 14, 2020 •

edited

Loading

maflcko commented Aug 14, 2020

fanquake commented Aug 14, 2020

jonasschnelli commented Aug 14, 2020

hebasto commented Aug 14, 2020

promag commented Aug 16, 2020 •

edited

Loading

vasild commented Aug 19, 2020

fanquake commented Aug 19, 2020

DrahtBot commented Aug 20, 2020 •

edited

Loading

fanquake commented Aug 24, 2020

hebasto commented Aug 25, 2020

maflcko commented Aug 25, 2020

hebasto commented Aug 25, 2020 •

edited

Loading

hebasto commented Aug 25, 2020

hebasto commented Aug 25, 2020

hebasto commented Aug 25, 2020

hebasto commented Aug 25, 2020

DrahtBot commented Feb 12, 2021

maflcko commented Feb 13, 2021

DrahtBot commented Mar 3, 2021

fanquake commented Mar 3, 2021

build: Qt 5.15.x #19716

build: Qt 5.15.x #19716

Conversation

fanquake commented Aug 14, 2020 • edited Loading

maflcko commented Aug 14, 2020

fanquake commented Aug 14, 2020

jonasschnelli commented Aug 14, 2020

hebasto commented Aug 14, 2020

promag commented Aug 16, 2020 • edited Loading

vasild commented Aug 19, 2020

fanquake commented Aug 19, 2020

DrahtBot commented Aug 20, 2020 • edited Loading

Conflicts

fanquake commented Aug 24, 2020

hebasto commented Aug 25, 2020

maflcko commented Aug 25, 2020

hebasto commented Aug 25, 2020 • edited Loading

hebasto commented Aug 25, 2020

hebasto commented Aug 25, 2020

hebasto commented Aug 25, 2020

hebasto commented Aug 25, 2020

DrahtBot commented Feb 12, 2021

Gitian builds

maflcko commented Feb 13, 2021

DrahtBot commented Mar 3, 2021

fanquake commented Mar 3, 2021

fanquake commented Aug 14, 2020 •

edited

Loading

promag commented Aug 16, 2020 •

edited

Loading

DrahtBot commented Aug 20, 2020 •

edited

Loading

hebasto commented Aug 25, 2020 •

edited

Loading