Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Qt 5.15.2 #2483

Closed
wants to merge 38 commits into from
Closed

Conversation

barton2526
Copy link
Member

@barton2526 barton2526 commented Apr 5, 2022

Opening this for visibility. Apart from it probably being time to use a newer version of Qt for releases, an update is required so that we are using a version which has a C++17 mode.

The biggest change here is that Qt no longer has internal xcb libs, so we need to build the requirements ourselves.

Ref: bitcoin/bitcoin#19716
Ref: bitcoin/bitcoin#23489

@barton2526 barton2526 marked this pull request as ready for review April 6, 2022 18:33
@barton2526
Copy link
Member Author

barton2526 commented Apr 6, 2022

CI is failing on Windows. Any assistance in debugging would be appreciated.

Here is the error I see locally:

In file included from rhi/qrhi.cpp:49:0:
rhi/qrhid3d11_p_p.h:57:10: fatal error: dxgi1_3.h: No such file or directory
 #include <dxgi1_3.h>
          ^~~~~~~~~~~
compilation terminated.
Makefile.Release:71665: recipe for target '.obj/release/qrhi.o' failed```

@barton2526
Copy link
Member Author

Here is a patch we could use
bitcoin/bitcoin#19716 (comment)

@barton2526
Copy link
Member Author

barton2526 commented Apr 6, 2022

This currently compiles for me on Windows 10 WSL cross-compile (Ubuntu Bionic)

image

barton2526 and others added 2 commits April 6, 2022 19:48
… CI to Focal

Co-Authored-By: div72 <60045611+div72@users.noreply.github.com>
barton2526 and others added 2 commits April 7, 2022 14:54
Co-Authored-By: div72 <60045611+div72@users.noreply.github.com>
ci: change windows CI to Focal, modify wrap_wine to use wine64 for 64bit binaries
@jamescowens
Copy link
Member

@barton2526 please rebase this to development now that I merged #2484.

@barton2526
Copy link
Member Author

Moved to #2486

@barton2526 barton2526 closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants