Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install fails #624

Closed
doitian opened this issue May 23, 2019 · 2 comments · Fixed by #626
Closed

make install fails #624

doitian opened this issue May 23, 2019 · 2 comments · Fixed by #626

Comments

@doitian
Copy link
Contributor

doitian commented May 23, 2019

It passes the same file twice to install command.

/usr/bin/install -c -m 644 include/secp256k1.h include/secp256k1_ecdh.h include/secp256k1_recovery.h include/secp256k1_recovery.h '/usr/local/include'
/usr/bin/install: will not overwrite just-created '/usr/local/include/secp256k1_recovery.h' with 'include/secp256k1_recovery.h'
Makefile:1151: recipe for target 'install-includeHEADERS' failed
make[1]: *** [install-includeHEADERS] Error 1
make[1]: Leaving directory '/home/travis/secp256k1'
Makefile:1578: recipe for target 'install-am' failed
make: *** [install-am] Error 2
@doitian
Copy link
Contributor Author

doitian commented May 24, 2019

It seems introduced in 91fae3a

@doitian
Copy link
Contributor Author

doitian commented May 24, 2019

Reproduce:

./configure --enable-module-recovery

doitian added a commit to doitian/secp256k1 that referenced this issue May 24, 2019
The module headers are already added in the top `Makefile.am`, which is
introduced in 91fae3a, but the module
`Makefile.am.include` will add the headers again.

Steps to reproduce the issue:

    ./autogen.sh
    ./configure --enable-module-recovery --prefix /tmp/secp256k1
    make
    make install

Failure message:

    /usr/bin/install -c -m 644 include/secp256k1.h include/secp256k1_ecdh.h include/secp256k1_recovery.h include/secp256k1_recovery.h '/usr/local/include'
    /usr/bin/install: will not overwrite just-created '/usr/local/include/secp256k1_recovery.h' with 'include/secp256k1_recovery.h'
    Makefile:1151: recipe for target 'install-includeHEADERS' failed
    make[1]: *** [install-includeHEADERS] Error 1
    make[1]: Leaving directory '/home/travis/secp256k1'
    Makefile:1578: recipe for target 'install-am' failed
    make: *** [install-am] Error 2

Closes bitcoin-core#624
doitian added a commit to nervosnetwork/ckb-sdk-ruby that referenced this issue May 24, 2019
gmaxwell added a commit that referenced this issue May 24, 2019
662918c Revert "Merge #620: Install headers automatically" (ian)

Pull request description:

  This reverts commit 91fae3a, reversing
  changes made to 5df77a0.

  See discussion in #625

  After the change, if we enable any module, `make install` fails because of the
  duplicated files in the command line arguments.

  Closes #624

Tree-SHA512: 7769ede527ac307bff094603e5974c56b19e41bc2ef55113173d3dbc8e545d6add7ae044753fa0361595e5e7a746d6c8d641f98caa3381b683aa2b61a1742097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant